You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Rémy Maucherat <re...@apache.org> on 2019/04/01 07:36:10 UTC
Re: [tomcat] 01/01: Fix wrong protocol version usage
On Sun, Mar 31, 2019 at 7:38 PM Michael Osipov <mi...@apache.org> wrote:
> Am 2019-03-31 um 14:50 schrieb Konstantin Kolinko:
> > -1 (veto).
> > This was discussed several years ago, and the decision was to use
> "HTTP/2.0"
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=58605
>
> I tripped over this when comparing access logs between Tomcat and
> Apache. Also, as you have noted, according to the RFC, it is HTTP/2, not
> HTTP/2.0. Only the PRI request uses HTTP/2.0 for compat reasons.
>
> I don't see a reason to keep an incorrect proto version. Just because
> Mozilla makes it wrong, it doens't mean we have to.
>
The commit was vetoed with a reason given, so it should be reverted for
now, and then discussion may continue on the merits.
Rémy
Re: [tomcat] 01/01: Fix wrong protocol version usage
Posted by Rémy Maucherat <re...@apache.org>.
On Mon, Apr 1, 2019 at 9:48 AM Michael Osipov <mi...@apache.org> wrote:
> Am 2019-04-01 um 09:36 schrieb Rémy Maucherat:
> > On Sun, Mar 31, 2019 at 7:38 PM Michael Osipov <mi...@apache.org>
> wrote:
> >
> >> Am 2019-03-31 um 14:50 schrieb Konstantin Kolinko:
> >>> -1 (veto).
> >>> This was discussed several years ago, and the decision was to use
> >> "HTTP/2.0"
> >>> https://bz.apache.org/bugzilla/show_bug.cgi?id=58605
> >>
> >> I tripped over this when comparing access logs between Tomcat and
> >> Apache. Also, as you have noted, according to the RFC, it is HTTP/2, not
> >> HTTP/2.0. Only the PRI request uses HTTP/2.0 for compat reasons.
> >>
> >> I don't see a reason to keep an incorrect proto version. Just because
> >> Mozilla makes it wrong, it doens't mean we have to.
> >>
> >
> > The commit was vetoed with a reason given, so it should be reverted for
> > now, and then discussion may continue on the merits.
>
> The commit is not part of the master branch. I have intentionally
> created a PR. I don't like the CTR approach because it procudes mess in
> the first place on the commit log.
>
> I am happy if we can have that discussion on the mailing list or on the
> PR. For now, only Konstantin has objected, I'd like to hear other
> comitter's opinion on.
>
Correct, the branch name is mentioned in the commit message and I missed
it, I'm simply not used to it yet.
Rémy
Re: [tomcat] 01/01: Fix wrong protocol version usage
Posted by Michael Osipov <mi...@apache.org>.
Am 2019-04-01 um 09:36 schrieb Rémy Maucherat:
> On Sun, Mar 31, 2019 at 7:38 PM Michael Osipov <mi...@apache.org> wrote:
>
>> Am 2019-03-31 um 14:50 schrieb Konstantin Kolinko:
>>> -1 (veto).
>>> This was discussed several years ago, and the decision was to use
>> "HTTP/2.0"
>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=58605
>>
>> I tripped over this when comparing access logs between Tomcat and
>> Apache. Also, as you have noted, according to the RFC, it is HTTP/2, not
>> HTTP/2.0. Only the PRI request uses HTTP/2.0 for compat reasons.
>>
>> I don't see a reason to keep an incorrect proto version. Just because
>> Mozilla makes it wrong, it doens't mean we have to.
>>
>
> The commit was vetoed with a reason given, so it should be reverted for
> now, and then discussion may continue on the merits.
The commit is not part of the master branch. I have intentionally
created a PR. I don't like the CTR approach because it procudes mess in
the first place on the commit log.
I am happy if we can have that discussion on the mailing list or on the
PR. For now, only Konstantin has objected, I'd like to hear other
comitter's opinion on.
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org