[GitHub] [incubator-superset] rusackas commented on pull request #10355: feat: SIP-34 explore save modal

[GitBox <gi...@apache.org>]

rusackas commented on pull request #10355:
URL: https://github.com/apache/incubator-superset/pull/10355#issuecomment-661473074


   > @Steejay , I decided to use the "CreatableSelect" component feature from react-select to avoid having to build the select box.
   > <img alt="Screen Shot 2020-07-18 at 4 47 53 PM" width="744" src="https://user-images.githubusercontent.com/487433/87863954-8ec59b80-c916-11ea-8860-1409d6bcca36.png">
   > 
   > <img alt="Screen Shot 2020-07-18 at 4 51 03 PM" width="673" src="https://user-images.githubusercontent.com/487433/87863978-ecf27e80-c916-11ea-9164-db75428487b3.png">
   > 
   > I also improved the e2e cypress tests quite a bit, fixed and re-enabled tests that had been disabled.
   
   The more I look at this the more I'm agonizing over the `🔘 Save (overwrite) 🔘 Save As` choice.
   
   Could it just be:
   ```
   Save as:
   [SomeChartame         ]
   ⚠️ Warning: This will overwrite the current *SomeChartame* chart
   ```
   ^ Just displaying an overwrite warning, rather than forcing a choice?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org