You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Andrew McIntyre (JIRA)" <de...@db.apache.org> on 2006/09/13 21:27:23 UTC
[jira] Created: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
-------------------------------------------------------------------------------------------
Key: DERBY-1846
URL: http://issues.apache.org/jira/browse/DERBY-1846
Project: Derby
Issue Type: Improvement
Components: Demos/Scripts
Affects Versions: 10.2.1.0
Reporter: Andrew McIntyre
Assigned To: Andrew McIntyre
Fix For: 10.2.1.0
Attachments: derby-1846-v1.diff
Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12435979 ]
Andrew McIntyre commented on DERBY-1846:
----------------------------------------
Thanks for the review John. I have found several other issues with the scripts as well, and i'll incorporate your suggested changes when I commit the improvements.
Currently the scripts don't produce usable jars because we need to patch up modules.properties to include the JDBC4 driver properties.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "John H. Embretsen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=all ]
John H. Embretsen updated DERBY-1846:
-------------------------------------
Attachment: output_batchFix_v1.txt
derby1846-batchFix_v1.diff
I have also tried the batch script on a Windows XP box. I found four issues:
1)
Missing @echo off - the output is very messy without it
2)
The cleanup command "@erase /s /q %DERBY_HOME%/jdbc4classes" should use a backslash instead of a forward slash when specifying the jdkc4classes directory. Here is the output I get with 1) fixed:
"Building Derby client classes for JDBC 4.0"
"Updating c:\programfiler\derby\sandboxes\bin-10.2.1.3\db-derby-10.2.1.3-bin\lib\derbyclient.jar"
"Building Derby engine classes for JDBC 4.0"
"Updating c:\programfiler\derby\sandboxes\bin-10.2.1.3\db-derby-10.2.1.3-bin\lib\derby.jar"
"Cleaning up"
Invalid switch - "jdbc4classes".
"Done."
3)
Double quotes around the echo strings are displayed as-is, as shown above. It looks more professional without them, and it still works (on my machine at least).
4)
The cleanup command mentioned in 2) does not delete the empty directories after deleting the JDBC 4 class files. Perhaps the rmdir command works better?
I have attached a patch fixing issues 1), 2) and 3), 'derby1846-batchFix_v1.diff', and the resulting output, output_batchFix_v1.txt
I tested the script by running it from trunk, with DERBY_HOME pointing to a 10.2.1.3-beta installation where I replaced the jars in lib/ with jars from the trunk, without JDBC 4. I looked for org/apache/derby/.../xxx40.class file entries in the derby.jar file (jar tf derby.jar), as a preliminary quick check. I'm sure there are better ways to check whether or not the script was successful...
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=all ]
Andrew McIntyre updated DERBY-1846:
-----------------------------------
Attachment: derby-1846-v1.diff
Attaching a patch with a shell script for this. Working on a batch version also, but thought I would go ahead and post the shell script so that people could review it.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: OK to ship junit.jar? (Was: (DERBY-1846) Create a script...)
Posted by Rick Hillegas <Ri...@Sun.COM>.
Knut Anders Hatlen wrote:
>"Andrew McIntyre (JIRA)" <de...@db.apache.org> writes:
>
>
>
>>
>>Andrew McIntyre commented on DERBY-1846:
>>----------------------------------------
>>
>>The jdbc4 classes depend on junit, which we are not able to ship.
>>
>>
>[...]
>
>The source distribution contains junit.jar. Is that a problem?
>
>
>
That jar isn't under source control. I don't think we should be shipping
it. If we do ship it, then we probably have to add some verbiage to the
NOTICE file since junit is distributed under a non-Apache license (I
continue to not be a lawyer). I vote for removing junit.jar from the
source distributions.
Regards,
-Rick
OK to ship junit.jar? (Was: (DERBY-1846) Create a script...)
Posted by Knut Anders Hatlen <Kn...@Sun.COM>.
"Andrew McIntyre (JIRA)" <de...@db.apache.org> writes:
>
> Andrew McIntyre commented on DERBY-1846:
> ----------------------------------------
>
> The jdbc4 classes depend on junit, which we are not able to ship.
[...]
The source distribution contains junit.jar. Is that a problem?
--
Knut Anders
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436953 ]
Andrew McIntyre commented on DERBY-1846:
----------------------------------------
The jdbc4 classes depend on junit, which we are not able to ship. Since we cannot guarantee that junit.jar will be there and I don't think adding an extra step is desirable in order to keep things as simple as possible, I don't think compiling the test classes is something worth pursuing, especially considering that these scripts will probably only be needed for the 10.2.1 release.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-netconnection.diff, derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436027 ]
Andrew McIntyre commented on DERBY-1846:
----------------------------------------
Ah, the joys of making scripts work everywhere. Rick, can you try replacing the '\\' in the script with \\\\ and let me know if that fixes your problem?
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12434539 ]
David Van Couvering commented on DERBY-1846:
--------------------------------------------
Hi, Andrew, thanks for jumping on this! Is there any reason this isn't an ant script? Is it so that users don't have to download ant? I'm concerned that not everyone has a shell environment, especially those on Windows. Are we going to build a .bat version as well?
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436057 ]
Rick Hillegas commented on DERBY-1846:
--------------------------------------
Hi Andrew,
Adding the '\\' fixes the build problem on Linux. I'm getting odd results at run-time however. The network version of the jdbc4 suite runs cleanly against the patched jar files. However, I'm getting abstract method errors during the embedded run of the suite. For some reason, the test is picking up EmbedConnection30 as the connection class even though I can see EmbedConnection40 in derby.jar.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436059 ]
Andrew McIntyre commented on DERBY-1846:
----------------------------------------
org/apache/derby/modules.properties in derby.jar needs to be updated to include the information about the JDBC 4 driver. It sounds like something went wrong with the update. That should be handled by the part of the script starting with "# patch up modules.properties so the driver will load"
The update is very simple: unpack modules.properties from derby.jar, then cat the needed updates to the end, trimming the line endings as necessary. It then is picked up with the rest of the classes when derby.jar is updated. Can you check and see what happened to modules.properties during the update?
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=all ]
Andrew McIntyre resolved DERBY-1846.
------------------------------------
Resolution: Fixed
Derby Info: (was: [Patch Available])
Marking resolved, no further work planned on this issue.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-netconnection.diff, derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "John H. Embretsen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436579 ]
John H. Embretsen commented on DERBY-1846:
------------------------------------------
The "NetConnection is not abstract" error went away after I recompiled the non-JDBC4 jars (ant clobber;ant all;ant buildjarsclean) and copied them to my $DERBY_HOME/lib (after deleting the old ones). The error was probably caused by me running svn update (getting updates from last night) and forgetting to recompile and rebuild the jars.
The jdbc40 suite passed in both Embedded and DerbyNetClient frameworks with updated jars (using a derbyTesting.jar with jdbc4 tests included, of course). I must say I admire your scripting skills, Andrew :)
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12434568 ]
Andrew McIntyre commented on DERBY-1846:
----------------------------------------
Committed to trunk with revision 443167. Leaving open until merged to 10.2
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andreas Korneliussen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436565 ]
Andreas Korneliussen commented on DERBY-1846:
---------------------------------------------
I think the script update-with-jdbc4 as it is now in SVN has a dangling-else problem if JAVA_HOME is set. The scripts sets my JAVA_HOME to /usr/j2se
After modifying the script from:
-if [ -z "$JAVA_HOME" ]; then
- if [ -n "$darwin" ]; then
- JAVA_HOME=/System/Library/Frameworks/JavaVM.framework/Home
- fi else if [ -d /usr/j2se -a -x /usr/j2se/bin/javac ]; then
- JAVA_HOME=/usr/j2se
to:
+
+if [ -n "$JAVA_HOME" ]; then
+ test
+else
+ if [ -n "$darwin" ]; then
+ JAVA_HOME=/System/Library/Frameworks/JavaVM.framework/Home
+ else
+ if [ -d /usr/j2se -a -x /usr/j2se/bin/javac ]; then
+ JAVA_HOME=/usr/j2se
+ fi
I got past this problem. I am not a shell-expert so there is probably a better solution.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andreas Korneliussen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436798 ]
Andreas Korneliussen commented on DERBY-1846:
---------------------------------------------
I have successfully used this script now on solarisx86. My previous test was from the 10.2 branch.
To test it, I did the following:
1. Compiled my sources without jdbc4 :ant clobber all buildcleanjars
2. In my trunk directory, added a softlink: ln -s jars/sane lib (to simulate a distribution)
3. Set DERBY_HOME to my trunk directory
4.Set JAVA_HOME to my jdk1.6.0 installation
Now, I ran the script, and it compiled all the jdbc4 stuff, and added the classes to the jar files.
I think this script is very useful if we make a binary release of Derby with JDBC4 as source. Then users can compile jdbc4 wihtout downloading java 1.3, java 1.4, ant, and other libraries which are required to compile the Derby engine.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-netconnection.diff, derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12437677 ]
Rick Hillegas commented on DERBY-1846:
--------------------------------------
Thanks, Andrew. Looks good to me. I ran the following experiment on a Linux machine:
1) Untarred the 10.2.1.5 bin distribution and pointed DERBY_HOME at the root of the untarred tree (the directory containing LICENSE).
2) Set my java environment to be jdk 1.6 build 99.
3) Untarred the 10.2.1.5 src distribution and cd'd to tools/jdbc4 inside the untarred tree.
4) Gave execute permission to update-with-jdbc4.
5) Ran that script.
The script compiled the optional JDBC4 driver classes and stuffed them into derby.jar and derbyclient.jar. I then continued:
6) Copied over a derbyTesting.jar from a 10.2 build.
7) Ran the jdbc4 suite in embedded and DerbyNetClient frameworks.
The tests ran cleanly. Thanks again!
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.5
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.5
>
> Attachments: derby-1846-netconnection.diff, derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-1846) Create a script that allows users
to easily update their Derby jars with the JDBC4 classes.
Posted by Rick Hillegas <Ri...@Sun.COM>.
John H. Embretsen wrote:
> Daniel John Debrunner wrote:
>
>>> Rick Hillegas commented on DERBY-1846:
>>> --------------------------------------
>>>
>>> I'm afraid I don't understand the workaround. It appears that John
>>> regenerated all of the jars from scratch.
>>
>
> I was doing that to "simulate" a 10.2.1.x bin-distribution, i.e. jars
> without JDBC 4. Since my sources were out of sync with the non-JDBC
> jars that were to be updated, the compiler complained.
Hm. I'm working with a 10.2.1.4 distribution built without JDBC4 classes
by the release generation machinery. I'm still seeing the compiler
problem on NetConnection when I run the update-with-jdbc4 script.
>
>>> If we're going to do that, then why are we writing this script in
>>> the first place? Why don't we just tell the users:
>>>
>>> 1) Unzip the source distribution.
>>>
>>> 2) Point ant.properties at your JDK 6 installation.
>>>
>>> 3) Build Derby.
>>
>>
>> If it's as simple as that, why do we need another script?
>>
>> Dan.
>>
>
> I think it was mainly so that users won't have to download ant, set it
> up and do all the other things required by BUILDING.txt. See
> http://issues.apache.org/jira/browse/DERBY-1846#action_12434544.
>
> The scripts are very useful, but not strictly necessary. See the
> description for DERBY-1846.
>
>
Re: [jira] Commented: (DERBY-1846) Create a script that allows users
to easily update their Derby jars with the JDBC4 classes.
Posted by "John H. Embretsen" <Jo...@Sun.COM>.
Daniel John Debrunner wrote:
>> Rick Hillegas commented on DERBY-1846:
>> --------------------------------------
>>
>> I'm afraid I don't understand the workaround. It appears that John regenerated all of the jars from scratch.
I was doing that to "simulate" a 10.2.1.x bin-distribution, i.e. jars
without JDBC 4. Since my sources were out of sync with the non-JDBC jars
that were to be updated, the compiler complained.
>> If we're going to do that, then why are we writing this script in the first place? Why don't we just tell the users:
>>
>> 1) Unzip the source distribution.
>>
>> 2) Point ant.properties at your JDK 6 installation.
>>
>> 3) Build Derby.
>
> If it's as simple as that, why do we need another script?
>
> Dan.
>
I think it was mainly so that users won't have to download ant, set it
up and do all the other things required by BUILDING.txt. See
http://issues.apache.org/jira/browse/DERBY-1846#action_12434544.
The scripts are very useful, but not strictly necessary. See the
description for DERBY-1846.
--
John
Re: [jira] Commented: (DERBY-1846) Create a script that allows users
to easily update their Derby jars with the JDBC4 classes.
Posted by Daniel John Debrunner <dj...@apache.org>.
Rick Hillegas (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436608 ]
>
> Rick Hillegas commented on DERBY-1846:
> --------------------------------------
>
> I'm afraid I don't understand the workaround. It appears that John regenerated all of the jars from scratch. If we're going to do that, then why are we writing this script in the first place? Why don't we just tell the users:
>
> 1) Unzip the source distribution.
>
> 2) Point ant.properties at your JDK 6 installation.
>
> 3) Build Derby.
If it's as simple as that, why do we need another script?
Dan.
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436608 ]
Rick Hillegas commented on DERBY-1846:
--------------------------------------
I'm afraid I don't understand the workaround. It appears that John regenerated all of the jars from scratch. If we're going to do that, then why are we writing this script in the first place? Why don't we just tell the users:
1) Unzip the source distribution.
2) Point ant.properties at your JDK 6 installation.
3) Build Derby.
4) Viola!
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436604 ]
Andrew McIntyre commented on DERBY-1846:
----------------------------------------
Running the script will do, that's what we're trying to get to work.
As for the error with NetConnection, see note from John, he ran into a similar error after running 'svn up' and needed to rebuild his non-JDBC4 jars: http://issues.apache.org/jira/browse/DERBY-1846#action_12436579
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436603 ]
Rick Hillegas commented on DERBY-1846:
--------------------------------------
Hi Andrew,
I'm not sure what experiment you want me to run. This is what I did:
1) I svn updated my Linux workspace in order to get your latest changes to update-with-jdbc4
2) Then a ran that script
It failed as follows:
sungod024 jdbc4 (1.6) > ./update-with-jdbc4
Compiling the client classes for JDBC 4.0
/home/rh161140/derby/mainline/trunk/java/client/org/apache/derby/client/net/NetConnection.java:43: org.apache.derby.clie
nt.net.NetConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Objec
t[]) in java.sql.Connection
public class NetConnection extends org.apache.derby.client.am.Connection {
^
Note: /home/rh161140/derby/mainline/trunk/java/client/org/apache/derby/client/net/NetConnection.java uses unchecked or u
nsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
There was an error compiling the client classes. Exiting.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436571 ]
Andrew McIntyre commented on DERBY-1846:
----------------------------------------
John: not sure about this error:
org.apache.derby.client.net.NetConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
A compiled version of NetConnection should already be on the classpath, so the compiler should not be trying to recompile it. I saw something similar on Windows, though, which I fixed by expanding the class into the output directory before calling javac. I'll let you know if I hit this in my Linux testing today.
Andreas: that should (hopefully) already be fixed in the latest version of the script. let me know if it is not.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436025 ]
Rick Hillegas commented on DERBY-1846:
--------------------------------------
I tried update-with-jdbc4 on Linux and saw a lot of the following diagnostics as the script looped through the client classes:
# compile the client classes
echo "Compiling the client classes for JDBC 4.0"
Compiling the client classes for JDBC 4.0
for i in `cat client.list`
do
FILE=`echo $i | tr '\\' '/' | sed 's/.$//g'`
CLASSES="$FILE $CLASSES"
done
cat client.list
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
echo $i | tr '\' '/' | sed 's/.$//g'
tr: invalid backslash escape at end of string
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12434544 ]
Andrew McIntyre commented on DERBY-1846:
----------------------------------------
Yes, so you don't have to download Ant. I did say that I would build a batch version. It won't be quite as nice as the shell script, but it will get the job done. E.g. the batch script won't check that the jvm you are running with is a 1.6 VM, since Windows has no string manipulation /comparison utilities like sed or expr and it won't do any error checking.
Almost everyone has a shell (or cmd.exe on windows). If you think an Ant build.xml would also be useful, feel free to put one together.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=all ]
Andrew McIntyre closed DERBY-1846.
----------------------------------
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.6
>
> Attachments: derby-1846-netconnection.diff, derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "John H. Embretsen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12435742 ]
John H. Embretsen commented on DERBY-1846:
------------------------------------------
I tried the 'update-with-jdbc4' script on a Solaris box (default shell is bash), and it failed with the message
"The JVM in $JAVA_HOME is not version 1.6.0
To use this script to compile the JDBC 4.0 Derby classes,
you need a 1.6.0 level VM"
But $JAVA_HOME was indeed set to a JDK 1.6 installation before running the script.
There seems to be a problem with the following check in the script:
if [ -z "$JAVA_HOME" ]; then
if [ -n "$darwin" ]; then
JAVA_HOME=/System/Library/Frameworks/JavaVM.framework/Home
fi else if [ -d /usr/j2se -a -x /usr/j2se/bin/javac ]; then
JAVA_HOME=/usr/j2se
fi
fi
I say this because in my environment, JAVA_HOME is always set to /usr/j2se by the script (I added an echo statement to verify this), and since that location contains a JDK 1.4.2 installation, the subsequent version check fails (I later modified the script so that it would echo something if the first condition shown above is true. It did not, meaning that JAVA_HOME was set, but that the script modified it anyway).
Perhaps an if - elif - fi construct may be more usable in the Bourne shell?
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436945 ]
Andrew McIntyre commented on DERBY-1846:
----------------------------------------
The script does not compile the test classes, an oversight on my part. It would be very simple to add to the scripts, since compiling an entire directory of classes is much simpler than cherry-picking specific files out of a hierarchy. It looks like I might have missed the first candidate, but in case there's a second rc, i'll see what I can do to get the test classes compiled in.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-netconnection.diff, derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "John H. Embretsen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436552 ]
John H. Embretsen commented on DERBY-1846:
------------------------------------------
I tried the script again (from an updated trunk) on Solaris 10 x86, bash shell (version 3.00.16), and after doing the double-to-quadruple-backslash fix (at two places in the script), I get the following error:
--------8>---------------------------------------
Compiling the client classes for JDBC 4.0
/home/user/apache/Derby/clean/trunk/java/client/org/apache/derby/client/net/NetConnection.java:43: org.apache.derby.client.net.NetConnection is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
public class NetConnection extends org.apache.derby.client.am.Connection {
^
Note: /home/user/apache/Derby/clean/trunk/java/client/org/apache/derby/client/net/NetConnection.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
There was an error compiling the client classes. Exiting.
--------8>---------------------------------------
Not sure yet what is causing this. Could it be a user error? I hope someone else is able to try it on Solaris as well...
I also tried the updated batch script on Win XP, and it went fine - at least the jdbc40 suite passes in both Embedded and DerbyNetClient frameworks. The only thing I wanted to comment is that the script started out by reporting "The system cannot find the file specified", which is caused by trying to remove a %DERBY_HOME%\jdbc4classes directory that does not exist yet. No big deal, its just something that may scare users (unless it is documented properly).
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436397 ]
Andrew McIntyre commented on DERBY-1846:
----------------------------------------
The attached modules.properties has not been updated to include the JDBC 4 driver properties. You can try setting the update_jdbc4_debug flag and running the script to see if some sort of error is occurring that isn't being reported, or you could comment out the cleanup of the jdbc4classes at the end to inspect the modules.properties that was jarred up. Lastly, make sure that modules.patch in tools/jdbc4 looks correct for the driver properties.
In the meantime, I'll see if I can reproduce this on a Linux box of my own. What shell are you using? bash?
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=all ]
Rick Hillegas updated DERBY-1846:
---------------------------------
Attachment: modules.properties
Hi Andrew,
I've attached the modules.properties from the patched derby.jar which gives rise to the abstract method errors. A further detail: I wrote a test program which verifies the following: If I run with a security manager and the test policy, then I get a 30 connection, but if I run without a security manager, then I get a 40 connection.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=all ]
Andrew McIntyre updated DERBY-1846:
-----------------------------------
Attachment: derby-1846-v2.diff
Updated patch which includes a batch file.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436593 ]
Andrew McIntyre commented on DERBY-1846:
----------------------------------------
Committed fix for issue with tr on Linux with revision 448617. Rick, I couldn't reproduce the issue with the modules.properties patch that you reported on Linux. Could you please recheck with the latest version of the script and modules.patch?
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436007 ]
Andrew McIntyre commented on DERBY-1846:
----------------------------------------
Committed vastly improved scripts with revision 447970. Jars updated with these scripts pass the JDBC 4 suite. Main fix was to patch up modules.properties, there are many other improvements to get the scripts to work in Cygwin, MKS, bash/tcsh, etc.
I'm satisfied with these scripts now, since the jars built with them pass the JDBC 4 suite. Always happy to hear suggestions for further improvements. Also, if anyone has the time to verify on, say, Solaris or Linux, that would be great.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=all ]
Andrew McIntyre updated DERBY-1846:
-----------------------------------
Attachment: derby-1846-netconnection.diff
Sorry, Rick, I'm unable to reproduce the problem you're seeing. Could you try two things?
a) remove $DERBY_HOME/jdbc4classes and try again. Maybe something stale from previous attempts is causing a problem.
b) if that doesn't work, try with the attached patch which expands NetConnection into the output dir, so that hopefully javac won't try to recompile it.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-netconnection.diff, derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1846) Create a script that allows users to
easily update their Derby jars with the JDBC4 classes.
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1846?page=comments#action_12436871 ]
Daniel John Debrunner commented on DERBY-1846:
----------------------------------------------
Does the script compile the test classes? From Andreas's description I would assume not, since a distribution is not laid out with derbyTesting.jar in lib. Would be good to document if it does or does not build the JD BC 4 tests in any instructions.
> Create a script that allows users to easily update their Derby jars with the JDBC4 classes.
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-1846
> URL: http://issues.apache.org/jira/browse/DERBY-1846
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.0
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.1.0
>
> Attachments: derby-1846-netconnection.diff, derby-1846-v1.diff, derby-1846-v2.diff, derby1846-batchFix_v1.diff, modules.properties, output_batchFix_v1.txt
>
>
> Since the resolution of the JDBC 4 licensing issue was to not ship a build that includes Derby's JDBC 4 code, but continue to ship the Derby source files for them, a script which automatically compiles and updates the Derby jars with the JDBC 4 classes would be useful.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira