[GitHub] [pulsar] eolivelli commented on a change in pull request #10374: [pulsar-broker] Fix: handle failed partitions topic creation

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #10374:
URL: https://github.com/apache/pulsar/pull/10374#discussion_r642940295



##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -445,10 +445,11 @@
      *            Number of new partitions of already exist partitioned-topic
      * @param updateLocalTopicOnly
      *            Used by broker for global topic with multiple replicated clusters
-     *
+     * @param force
+     *            Update forcefully without validating existing partitioned topic
      * @returns a future that can be used to track when the partitioned topic is updated
      */
-    void updatePartitionedTopic(String topic, int numPartitions, boolean updateLocalTopicOnly)
+    void updatePartitionedTopic(String topic, int numPartitions, boolean updateLocalTopicOnly, boolean force)

Review comment:
       it looks like we are dropping an API method.
   
   we should keep the existing method, and add a new one that falls back to the new method, with force=false




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org