You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/19 00:57:59 UTC

[GitHub] [incubator-superset] mistercrunch opened a new pull request #10363: chore: uniform icons across list views

mistercrunch opened a new pull request #10363:
URL: https://github.com/apache/incubator-superset/pull/10363


   <img width="1653" alt="Screen Shot 2020-07-18 at 5 56 50 PM" src="https://user-images.githubusercontent.com/487433/87864674-24195d80-c920-11ea-9d86-96e6dd9559da.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #10363: chore: uniform icons across list views

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10363:
URL: https://github.com/apache/incubator-superset/pull/10363#issuecomment-661480353


   Addressed comments!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10363: chore: uniform icons across list views

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10363:
URL: https://github.com/apache/incubator-superset/pull/10363#discussion_r457544391



##########
File path: superset-frontend/src/views/dashboardList/DashboardList.tsx
##########
@@ -173,7 +174,7 @@ class DashboardList extends React.PureComponent<Props, State> {
         },
       }: any) => (
         <span className="no-wrap">
-          {published ? <i className="fa fa-check" /> : ''}
+          {published ? <i className="fa fa-check text-muted" /> : ''}

Review comment:
       is this color supposed to match the other Icons? it doesn't currently. Maybe replace this with `<Icon name="check' />`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on a change in pull request #10363: chore: uniform icons across list views

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10363:
URL: https://github.com/apache/incubator-superset/pull/10363#discussion_r456947926



##########
File path: superset-frontend/images/icons/share.svg
##########
@@ -0,0 +1,25 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
+<g id="Icon / Share">
+<g id="upload">
+<path id="Shape" fill-rule="evenodd" clip-rule="evenodd" d="M8.71 7.71002L11 5.41002V15C11 15.5523 11.4477 16 12 16C12.5523 16 13 15.5523 13 15V5.41002L15.29 7.71002C15.4778 7.89933 15.7334 8.00582 16 8.00582C16.2666 8.00582 16.5222 7.89933 16.71 7.71002C16.8993 7.52225 17.0058 7.26666 17.0058 7.00002C17.0058 6.73338 16.8993 6.47779 16.71 6.29002L12.71 2.29002C12.6149 2.19898 12.5028 2.12761 12.38 2.08002C12.1365 1.98 11.8635 1.98 11.62 2.08002C11.4972 2.12761 11.3851 2.19898 11.29 2.29002L7.29 6.29002C7.03634 6.54368 6.93728 6.91339 7.03012 7.2599C7.12297 7.6064 7.39362 7.87705 7.74012 7.9699C8.08663 8.06274 8.45634 7.96368 8.71 7.71002ZM21 12C20.4477 12 20 12.4477 20 13V19C20 19.5523 19.5523 20 19 20H5C4.44772 20 4 19.5523 4 19V13C4 12.4477 3.55228 12 3 12C2.44772 12 2 12.4477 2 13V19C2 20.6569 3.34315 22 5 22H19C20.6569 22 22 20.6569 22 19V13C22 12.4477 21.5523 12 21 12Z" fill="#666666"/>

Review comment:
       Can you change this fill color to `currentColor` which should make it easy to set the `color` property in these icons. 

##########
File path: superset-frontend/src/components/Modal.tsx
##########
@@ -31,6 +31,15 @@ interface ModalProps {
   primaryButtonType?: 'primary' | 'danger';
   show: boolean;
   title: React.ReactNode;
+  bsSize?:
+    | 'xs'
+    | 'xsmall'
+    | 'sm'
+    | 'small'
+    | 'medium'
+    | 'lg'
+    | 'large'
+    | undefined;

Review comment:
       making a prop optional, via the `?`, automatically adds the `undefined` value. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch merged pull request #10363: chore: uniform icons across list views

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10363:
URL: https://github.com/apache/incubator-superset/pull/10363


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10363: chore: uniform icons across list views

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10363:
URL: https://github.com/apache/incubator-superset/pull/10363#discussion_r457761808



##########
File path: superset-frontend/src/components/DeleteModal.tsx
##########
@@ -62,13 +62,15 @@ export default function DeleteModal({
       primaryButtonType="danger"
       show={open}
       title={title}
+      bsSize="medium"

Review comment:
       bycatch 
   
   # after
   <img width="1022" alt="Screen Shot 2020-07-20 at 5 14 43 PM" src="https://user-images.githubusercontent.com/487433/87998374-8bfcaf00-caac-11ea-99e3-a2e7c39a456c.png">
   
   # before
   <img width="697" alt="Screen Shot 2020-07-20 at 5 14 11 PM" src="https://user-images.githubusercontent.com/487433/87998377-8c954580-caac-11ea-84ca-de0bb9f2863f.png">
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10363: chore: uniform icons across list views

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10363:
URL: https://github.com/apache/incubator-superset/pull/10363#discussion_r457761808



##########
File path: superset-frontend/src/components/DeleteModal.tsx
##########
@@ -62,13 +62,15 @@ export default function DeleteModal({
       primaryButtonType="danger"
       show={open}
       title={title}
+      bsSize="medium"

Review comment:
       bycatch 
   
   # before
   <img width="1022" alt="Screen Shot 2020-07-20 at 5 14 43 PM" src="https://user-images.githubusercontent.com/487433/87998374-8bfcaf00-caac-11ea-99e3-a2e7c39a456c.png">
   # after
   <img width="697" alt="Screen Shot 2020-07-20 at 5 14 11 PM" src="https://user-images.githubusercontent.com/487433/87998377-8c954580-caac-11ea-84ca-de0bb9f2863f.png">
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10363: chore: uniform icons across list views

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10363:
URL: https://github.com/apache/incubator-superset/pull/10363#issuecomment-660568270


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=h1) Report
   > Merging [#10363](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1a41ea49880520d296a7cb58f2d8ebccfbd5681a&el=desc) will **decrease** coverage by `5.07%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10363/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10363      +/-   ##
   ==========================================
   - Coverage   69.70%   64.63%   -5.08%     
   ==========================================
     Files         196      539     +343     
     Lines       18950    30417   +11467     
     Branches        0     2869    +2869     
   ==========================================
   + Hits        13210    19660    +6450     
   - Misses       5740    10583    +4843     
   - Partials        0      174     +174     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.88% <ø> (?)` | |
   | #python | `69.92% <ø> (+0.21%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/components/Icon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi50c3g=) | `100.00% <ø> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <0.00%> (ø)` | |
   | [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/components/CheckboxIcons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy5qc3g=) | `50.00% <0.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | `100.00% <0.00%> (ø)` | |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (ø)` | |
   | [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUFjdGl2ZUZpbHRlclZhbHVlcy5qcw==) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `14.52% <0.00%> (ø)` | |
   | ... and [349 more](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=footer). Last update [1a41ea4...8010009](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #10363: chore: uniform icons across list views

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #10363:
URL: https://github.com/apache/incubator-superset/pull/10363#discussion_r457730841



##########
File path: superset-frontend/src/views/dashboardList/DashboardList.tsx
##########
@@ -173,7 +174,7 @@ class DashboardList extends React.PureComponent<Props, State> {
         },
       }: any) => (
         <span className="no-wrap">
-          {published ? <i className="fa fa-check" /> : ''}
+          {published ? <i className="fa fa-check text-muted" /> : ''}

Review comment:
       +1 this. I think we should move to use our own svg/Icon component and finally remove Font Awesome. otherwise, i always feel confused which icon to use :(




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10363: chore: uniform icons across list views

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10363:
URL: https://github.com/apache/incubator-superset/pull/10363#issuecomment-660568270


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=h1) Report
   > Merging [#10363](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1a41ea49880520d296a7cb58f2d8ebccfbd5681a&el=desc) will **decrease** coverage by `5.35%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10363/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10363      +/-   ##
   ==========================================
   - Coverage   69.70%   64.35%   -5.36%     
   ==========================================
     Files         196      539     +343     
     Lines       18950    30417   +11467     
     Branches        0     2869    +2869     
   ==========================================
   + Hits        13210    19574    +6364     
   - Misses       5740    10661    +4921     
   - Partials        0      182     +182     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.13% <ø> (?)` | |
   | #python | `69.92% <ø> (+0.21%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/components/Icon.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi50c3g=) | `100.00% <ø> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [...et-frontend/src/SqlLab/components/LimitControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC5qc3g=) | `66.66% <0.00%> (ø)` | |
   | [...et-frontend/src/explore/controlPanels/Separator.js](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TZXBhcmF0b3IuanM=) | `0.00% <0.00%> (ø)` | |
   | [.../src/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLmpzeA==) | `90.76% <0.00%> (ø)` | |
   | [...nd/src/messageToasts/containers/ToastPresenter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29udGFpbmVycy9Ub2FzdFByZXNlbnRlci5qc3g=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `100.00% <0.00%> (ø)` | |
   | [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `60.00% <0.00%> (ø)` | |
   | [...t-frontend/src/explore/actions/saveModalActions.js](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9zYXZlTW9kYWxBY3Rpb25zLmpz) | `79.31% <0.00%> (ø)` | |
   | ... and [349 more](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=footer). Last update [1a41ea4...8010009](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10363: chore: uniform icons across list views

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10363:
URL: https://github.com/apache/incubator-superset/pull/10363#issuecomment-660568270


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=h1) Report
   > Merging [#10363](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5fa46804473ad1b3909aaef4bc1d4e729c048882&el=desc) will **decrease** coverage by `0.72%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10363/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10363      +/-   ##
   ==========================================
   - Coverage   70.48%   69.75%   -0.73%     
   ==========================================
     Files         603      196     -407     
     Lines       32427    19045   -13382     
     Branches     3294        0    -3294     
   ==========================================
   - Hits        22856    13285    -9571     
   + Misses       9467     5760    -3707     
   + Partials      104        0     -104     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `69.75% <ø> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `64.51% <0.00%> (-9.68%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.92% <0.00%> (-0.44%)` | :arrow_down: |
   | [superset-frontend/src/visualizations/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2NvbnN0YW50cy5qcw==) | | |
   | [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | | |
   | [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | | |
   | [superset-frontend/src/components/CheckboxIcons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy5qc3g=) | | |
   | [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | | |
   | [superset-frontend/src/utils/safeStringify.ts](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3NhZmVTdHJpbmdpZnkudHM=) | | |
   | [...dashboard/components/FilterIndicatorsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvcnNDb250YWluZXIuanN4) | | |
   | ... and [398 more](https://codecov.io/gh/apache/incubator-superset/pull/10363/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=footer). Last update [5fa4680...bb6e2d9](https://codecov.io/gh/apache/incubator-superset/pull/10363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org