You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "David Jacot (Jira)" <ji...@apache.org> on 2022/12/20 17:02:00 UTC

[jira] [Resolved] (KAFKA-14536) SessionId in FetchResponse should be ignorable

     [ https://issues.apache.org/jira/browse/KAFKA-14536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jacot resolved KAFKA-14536.
---------------------------------
    Resolution: Not A Problem

> SessionId in FetchResponse should be ignorable
> ----------------------------------------------
>
>                 Key: KAFKA-14536
>                 URL: https://issues.apache.org/jira/browse/KAFKA-14536
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: David Jacot
>            Assignee: David Jacot
>            Priority: Major
>
> SessionId was introduced in version 7 of the Fetch API. It is not ignorable in the schema definition and we have no code in the broker to not set it when an older version is used.
> It seems that we regressed when we switched the Fetch API from the struct based serialization to the automated protocol. [Here|https://github.com/apache/kafka/commit/4cd2396db31418c90005c998d9107ad40df055b2#diff-1ef70ab50c661cda6afb43edf35d5d0af011b83d6da3731cca73f77756a38d40L538]. We previously used `struct.setIfExists(SESSION_ID, sessionId);` which did that for us.
> Interestingly, it seems that our upgrade system tests did not catch it. I will investigate this further.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)