You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xtable.apache.org by "zhang-arvin (via GitHub)" <gi...@apache.org> on 2026/09/07 17:41:46 UTC
[PR] [Bug] Populate record_count for parquet source files [incubator-xtable]
zhang-arvin opened a new pull request, #929:
URL: https://github.com/apache/incubator-xtable/pull/929
Fixes #926
## What changes were proposed in this pull request?
`ParquetConversionSource` never populated `recordCount` on the `InternalDataFile`s it creates (both the full-sync and incremental paths), leaving it at the primitive default of 0. Both targets serialize that faithfully, so every registered file showed `record_count = 0` and engines answering aggregates from metadata (Spark's optimized `count(*)`, Iceberg's `.files`, Delta's `numRecords`) returned 0 rows for non-empty tables.
## How was this patch tested?
- `./mvnw -pl xtable-core -am -DskipTests compile`
- Existing `ITParquetConversionSource` suite covers the conversion paths (local run pending CI).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Populate record_count for parquet source files [incubator-xtable]
Posted by "zhang-arvin (via GitHub)" <gi...@apache.org>.
zhang-arvin closed pull request #929: fix: Populate record_count for parquet source files
URL: https://github.com/apache/incubator-xtable/pull/929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bug] Populate record_count for parquet source files [incubator-xtable]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on PR #929:
URL: https://github.com/apache/incubator-xtable/pull/929#issuecomment-5574404475
@zhang-arvin can you add or update some existing tests to ensure we don't regress in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Populate record_count for parquet source files [incubator-xtable]
Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 merged PR #929:
URL: https://github.com/apache/incubator-xtable/pull/929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org