You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/06/03 23:58:40 UTC
Re: Review Request 34319: Refactored os::getenv() to return an option
and removed os::hasenv()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34319/#review86485
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On May 25, 2015, 4:43 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34319/
> -----------------------------------------------------------
>
> (Updated May 25, 2015, 4:43 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-994
> https://issues.apache.org/jira/browse/MESOS-994
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored os::getenv to return an option and updated os::path accordingly, and removed os::hasenv
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp d2ca4be90edb134465751d093b61e84fd6b16f1c
>
> Diff: https://reviews.apache.org/r/34319/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>