You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2024/06/03 20:52:47 UTC
[I] chore: Make Comet compatible with Rust 1.78 [datafusion-comet]
andygrove opened a new issue, #507:
URL: https://github.com/apache/datafusion-comet/issues/507
### What is the problem the feature request solves?
Once https://github.com/apache/datafusion-comet/pull/505 is merged, we pin the project to stable Rust 1.77.
If I change this to 1.78 then I see many tests fail with `thread caused non-unwinding panic. aborting.`.
If I run the failing tests in debug mode then I see helpful warnings such as:
```
unsafe precondition(s) violated: slice::from_raw_parts requires the pointer to be aligned and non-null, and the total size of the slice not to exceed `isize::MAX`
```
In some cases we are trying to access elements in empty slices.
I am not 100% sure which changes in 1.78 are affecting us, but it is possible these are related:
- https://github.com/rust-lang/rust/pull/121201/
- https://github.com/rust-lang/rust/pull/120594/
### Describe the potential solution
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] [EPIC] Fix safety issues in unsafe code [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed issue #507: [EPIC] Fix safety issues in unsafe code
URL: https://github.com/apache/datafusion-comet/issues/507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] chore: Make Comet compatible with Rust 1.78 [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on issue #507:
URL: https://github.com/apache/datafusion-comet/issues/507#issuecomment-2156614044
These are the failing tests:
```
test execution::datafusion::spark_hash::tests::test_str ... thread caused non-unwinding panic. aborting.
test execution::sort::tests::test_rdxsort ... thread caused non-unwinding panic. aborting.
test parquet::util::hash_util::tests::test_crc32 ... thread caused non-unwinding panic. aborting.
test parquet::util::hash_util::tests::test_murmur2_64a ... thread caused non-unwinding panic. aborting.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org