[GitHub] [tomcat] markt-asf commented on a change in pull request #143: Apply deduplication to certain loaded and created Strings

[GitBox <gi...@apache.org>]

markt-asf commented on a change in pull request #143: Apply deduplication to certain loaded and created Strings
URL: https://github.com/apache/tomcat/pull/143#discussion_r307809324
 
 

 ##########
 File path: java/org/apache/tomcat/util/digester/SetPropertiesRule.java
 ##########
 @@ -62,7 +59,7 @@ public void begin(String namespace, String theName, Attributes attributes)
             if ("".equals(name)) {
                 name = attributes.getQName(i);
             }
-            String value = attributes.getValue(i);
+            String value = attributes.getValue(i).intern();
 
 Review comment:
   For the relatively small number of strings concerned, we did not observe any performance issues and intern() was considered to be a reasonable approach. Happy to review contrary data, should any be provided.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org