[jira] [Comment Edited] (SLING-5607) SlingServletResolver.resolveServlet should never return null

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195122#comment-15195122 ] 

Konrad Windszus edited comment on SLING-5607 at 3/15/16 11:29 AM:
------------------------------------------------------------------

I found only within Sling https://github.com/apache/sling/blob/trunk/bundles/scripting/sightly/engine/src/main/java/org/apache/sling/scripting/sightly/impl/engine/extension/IncludeRuntimeExtension.java#L103 which relies on the null return value. AEM contains at least one I know of (com.day.cq.wcm.tags.IncludeTag).


was (Author: kwin):
I found only within Sling https://github.com/apache/sling/blob/trunk/bundles/servlets/resolver/src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java#L277 which relies on the null return value. AEM contains at least one I know of (com.day.cq.wcm.tags.IncludeTag).

> SlingServletResolver.resolveServlet should never return null
> ------------------------------------------------------------
>
>                 Key: SLING-5607
>                 URL: https://issues.apache.org/jira/browse/SLING-5607
>             Project: Sling
>          Issue Type: Improvement
>          Components: Servlets
>    Affects Versions: Servlets Resolver 2.4.2
>            Reporter: Konrad Windszus
>
> According to the javadoc of the {{ServletResolver}} all resolve methods should never return {{null}} in case no servlet could be found but rather throw an exception.
> This issue was revealed in the context of SLING-5605.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)