You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by echarles <gi...@git.apache.org> on 2016/04/12 14:59:31 UTC
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
GitHub user echarles opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/831
[ZEPPELIN-798] Migrate to Jetty version 9
### What is this PR for?
Upgrade from Jetty 8 to Jetty 9 mainly for deadlock bug fix https://bugs.eclipse.org/bugs/show_bug.cgi?id=389645
Jetty 9 has changed the maven names and context building (for web and websocket).
### What type of PR is it?
[Bug Fix]
### Todos
* [x ] - Adapt the unit tests
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-798
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/datalayer/zeppelin-datalayer jetty9
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #831
----
commit 82d311a30efefb2a0088a8b8f71701b2bffb83f5
Author: Eric Charles <er...@datalayer.io>
Date: 2016-04-12T12:47:19Z
Upgrade to jetty 9
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by prasadwagle <gi...@git.apache.org>.
Github user prasadwagle commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-214041770
@echarles I tested this branch on my local machine but haven't deployed it to production yet. Since I deployed the workarounds I mentioned in [this](http://mail-archives.apache.org/mod_mbox/incubator-zeppelin-users/201604.mbox/%3CCAMKL62nmLDJRghYB39MdnbAiRT6wvso0eVePKRtKurmu5iM%2BuQ%40mail.gmail.com%3E) email thread, I haven't seen the deadlock issue for more than two weeks. The long term fix is moving to jetty 9 and I think we should merge this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by echarles <gi...@git.apache.org>.
GitHub user echarles reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/831
[ZEPPELIN-798] Migrate to Jetty version 9
### What is this PR for?
Upgrade from Jetty 8 to Jetty 9 mainly for deadlock bug fix https://bugs.eclipse.org/bugs/show_bug.cgi?id=389645
Jetty 9 has changed the maven names and context building (for web and websocket).
### What type of PR is it?
[Bug Fix]
### Todos
* [x ] - Adapt the unit tests
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-798
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/datalayer/zeppelin-datalayer jetty9
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #831
----
commit 82d311a30efefb2a0088a8b8f71701b2bffb83f5
Author: Eric Charles <er...@datalayer.io>
Date: 2016-04-12T12:47:19Z
Upgrade to jetty 9
commit c48d4b208fd12f0972a2c5e79c5c8475baa5a615
Author: Eric Charles <er...@datalayer.io>
Date: 2016-04-12T13:28:17Z
Add javadoc to NotebookWebSocketCreator class
commit 2a111d82deb357ba203aba46e441dd24639fc555
Author: Eric Charles <er...@datalayer.io>
Date: 2016-04-12T13:37:57Z
Exclude jetty websocket-client from htmlunit to ensure dependeny convergence
commit 05d9c50ca94126aa9f7b0a4cc05f15dc2abc7de2
Author: Eric Charles <er...@datalayer.io>
Date: 2016-04-12T14:31:53Z
Use jetty 9.2.15.v20160210 which is compatible with JDK-1.7
commit 8e3daebdcce670dd95e34e532f91603ea0f358d1
Author: Eric Charles <er...@datalayer.io>
Date: 2016-04-21T06:41:24Z
Merge branch 'master' into jetty9
commit 840bdb4544877642dedad120d9d65babb731271c
Author: Eric Charles <er...@datalayer.io>
Date: 2016-04-21T06:53:43Z
Use correct syntax for httpConfig and httpsConfig, thx @jongyoul for the review
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/831
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-208972267
CI is green *but* I have used 9.2.??? roughly 9 months ago and it have given "CPU leaks": after a few user requests, the CPU suddenly went to a constant 30% usage without apparent reasons, without coming back to a normal pressure.
Unless someones confirms that this branch sustains the load, I recommend not to merge as-is.
PS: After rolling back, I gave another try with 9.3 and it is working fine since a few months (but 9.3 requires jdk-1.8).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-208933458
@anthonycorbacho comments crossing... Just realized yes, we need JDK-1.8... Should I open a thread on user mailinglist?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-208932745
```
org.apache.zeppelin.rest.SecurityRestApiTest Time elapsed: 180.035 sec <<< ERROR!
java.lang.UnsupportedClassVersionError: org/eclipse/jetty/server/HttpConfiguration$Customizer : Unsupported major.minor version 52.0
```
This PR builds fine but fails on test as jetty9 is built for JDK-1.8 [1]
Time to move on to JDK-1.8?
[1] http://central.maven.org/maven2/org/eclipse/jetty/jetty-project/9.3.7.v20160115/jetty-project-9.3.7.v20160115.pom
```
<profile><id>eclipse-release</id><modules><module>aggregates/jetty-all</module></modules><build><plugins><plugin><artifactId>maven-compiler-plugin</artifactId><configuration><source>1.8</source><target>1.8</target> ...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-208934010
Or `9.2.2.v20140723` seems to be happy with jdk1.7... WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-208932229
@echarles dont you need `jdk8` with `9.3.7.v20160115` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-208934230
maybe `9.2.15.v20160210` should do the trick?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-209221661
@prasadwagle Reliability repoduce deadlocks is not possible IMHO. However, you can simulate load with tools like jmeter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-212781280
Timeout while downloading jars during travis build...
```
[WARNING] Could not transfer metadata org.apache.apache.resources:apache-jar-resource-bundle:1.5-SNAPSHOT/maven-metadata.xml from/to apache.snapshots (http://repository.apache.org/snapshots): Failed to transfer file: http://repository.apache.org/snapshots/org/apache/apache/resources/apache-jar-resource-bundle/1.5-SNAPSHOT/maven-metadata.xml. Return code is: 502 , ReasonPhrase:Proxy Error.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-214845739
LGTM
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-212142078
@echarles could you follow up on the review comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by prasadwagle <gi...@git.apache.org>.
Github user prasadwagle commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-209134954
Good work @echarles! I could run the zeppelin server my laptop with jetty 9.2 and jdk 1.8. We are using jdk 1.8 in production since we need bug fixes in the later versions of https://prestodb.io/ drivers that require jdk 1.8. I recommend stress testing with jetty 9.3 and jdk 1.8.
I don't know how to reliably reproduce the jetty 8 websocket deadlock bug to check if it is fixed. It started happening more frequently when we had around 20 simultaneous connections. Do we have a stress test that can simulate this environment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by echarles <gi...@git.apache.org>.
Github user echarles closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/831
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-213308657
@felixcheung back to green.
@prasadwagle Had you the chance to test this branch? Did it solve the deadlock issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-798] Migrate to Jetty v...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/831#issuecomment-213190438
+@bzz
This seems like an issue with Maven build pulling down dependencies. Try close/reopen PR at a different time of the day when Travis is less busy...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---