You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by wjm wjm <zz...@gmail.com> on 2019/04/28 15:28:40 UTC
[disscuss][java-chassis] plan to release java-chassis patch 1.2.1?
there are some important fix for 1.2.0
- when create microservice meta failed, will destroy failed meta, but
leak to destroy related configuration resources, rarely happen, but it's a
leak problem.
- when log framework is log4j2, will leak some log4j2 marker object for
every request, serious leak problem
- default to disable inject x-cse-context from edge invoker, to
avoid security issue problem
other changes:
- support consumer and producer return Optional type
- inspector swagger online test support work with servlet having web
root and servlet pattern
- inspector support view configuration items
- fix inspector swagger to html can not scroll problem
do we plan to release a patch 1.2.1?
Re: [disscuss][java-chassis] plan to release java-chassis patch 1.2.1?
Posted by wjm wjm <zz...@gmail.com>.
discussed with @willem.jiang <wi...@gmail.com> , because only
"Optional" is new feature, we can create 1.2.1 branch based on current
master(1.3.0-SNAPSHOT)
Willem Jiang <wi...@gmail.com> 于2019年4月29日周一 上午9:14写道：
> I think we can start from 1.2.0 to avoid introduce new feature of 1.3.0.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Mon, Apr 29, 2019 at 8:37 AM wjm wjm <zz...@gmail.com> wrote:
> >
> > create 1.2.1 branch based on current master(1.3.0-SNAPSHOT)
> > or create a new branch based on 1.2.0 and then cherry pick?
> >
> > Willem Jiang <wi...@gmail.com> 于2019年4月29日周一 上午8:22写道：
> >
> > > Yeah, we could release 1.2.1 for these important patches.
> > > As the 1.2.1 is a patch release, my suggestion is we back port the
> > > patches of bug fixing into the 1.2.x branch, and then cut the release
> > > candidate.
> > > @wjm do you mind mark the JIRAs of the bug with the fix version of
> > > 1.2.1, then we could start the cherry pick the patches into 1.2.x
> > > branch.
> > >
> > > Any thought?
> > >
> > >
> > > Willem Jiang
> > >
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > > On Sun, Apr 28, 2019 at 11:29 PM wjm wjm <zz...@gmail.com> wrote:
> > > >
> > > > there are some important fix for 1.2.0
> > > >
> > > >
> > > > - when create microservice meta failed, will destroy failed meta,
> but
> > > > leak to destroy related configuration resources, rarely happen,
> but
> > > it's a
> > > > leak problem.
> > > > - when log framework is log4j2, will leak some log4j2 marker
> object
> > > for
> > > > every request, serious leak problem
> > > > - default to disable inject x-cse-context from edge invoker, to
> > > > avoid security issue problem
> > > >
> > > >
> > > > other changes:
> > > >
> > > > - support consumer and producer return Optional type
> > > > - inspector swagger online test support work with servlet having
> web
> > > > root and servlet pattern
> > > > - inspector support view configuration items
> > > > - fix inspector swagger to html can not scroll problem
> > > >
> > > > do we plan to release a patch 1.2.1?
> > >
>
Re: [disscuss][java-chassis] plan to release java-chassis patch 1.2.1?
Posted by Willem Jiang <wi...@gmail.com>.
I think we can start from 1.2.0 to avoid introduce new feature of 1.3.0.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Mon, Apr 29, 2019 at 8:37 AM wjm wjm <zz...@gmail.com> wrote:
>
> create 1.2.1 branch based on current master(1.3.0-SNAPSHOT)
> or create a new branch based on 1.2.0 and then cherry pick?
>
> Willem Jiang <wi...@gmail.com> 于2019年4月29日周一 上午8:22写道：
>
> > Yeah, we could release 1.2.1 for these important patches.
> > As the 1.2.1 is a patch release, my suggestion is we back port the
> > patches of bug fixing into the 1.2.x branch, and then cut the release
> > candidate.
> > @wjm do you mind mark the JIRAs of the bug with the fix version of
> > 1.2.1, then we could start the cherry pick the patches into 1.2.x
> > branch.
> >
> > Any thought?
> >
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Sun, Apr 28, 2019 at 11:29 PM wjm wjm <zz...@gmail.com> wrote:
> > >
> > > there are some important fix for 1.2.0
> > >
> > >
> > > - when create microservice meta failed, will destroy failed meta, but
> > > leak to destroy related configuration resources, rarely happen, but
> > it's a
> > > leak problem.
> > > - when log framework is log4j2, will leak some log4j2 marker object
> > for
> > > every request, serious leak problem
> > > - default to disable inject x-cse-context from edge invoker, to
> > > avoid security issue problem
> > >
> > >
> > > other changes:
> > >
> > > - support consumer and producer return Optional type
> > > - inspector swagger online test support work with servlet having web
> > > root and servlet pattern
> > > - inspector support view configuration items
> > > - fix inspector swagger to html can not scroll problem
> > >
> > > do we plan to release a patch 1.2.1?
> >
Re: [disscuss][java-chassis] plan to release java-chassis patch 1.2.1?
Posted by wjm wjm <zz...@gmail.com>.
create 1.2.1 branch based on current master(1.3.0-SNAPSHOT)
or create a new branch based on 1.2.0 and then cherry pick?
Willem Jiang <wi...@gmail.com> 于2019年4月29日周一 上午8:22写道：
> Yeah, we could release 1.2.1 for these important patches.
> As the 1.2.1 is a patch release, my suggestion is we back port the
> patches of bug fixing into the 1.2.x branch, and then cut the release
> candidate.
> @wjm do you mind mark the JIRAs of the bug with the fix version of
> 1.2.1, then we could start the cherry pick the patches into 1.2.x
> branch.
>
> Any thought?
>
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Sun, Apr 28, 2019 at 11:29 PM wjm wjm <zz...@gmail.com> wrote:
> >
> > there are some important fix for 1.2.0
> >
> >
> > - when create microservice meta failed, will destroy failed meta, but
> > leak to destroy related configuration resources, rarely happen, but
> it's a
> > leak problem.
> > - when log framework is log4j2, will leak some log4j2 marker object
> for
> > every request, serious leak problem
> > - default to disable inject x-cse-context from edge invoker, to
> > avoid security issue problem
> >
> >
> > other changes:
> >
> > - support consumer and producer return Optional type
> > - inspector swagger online test support work with servlet having web
> > root and servlet pattern
> > - inspector support view configuration items
> > - fix inspector swagger to html can not scroll problem
> >
> > do we plan to release a patch 1.2.1?
>
Re: [disscuss][java-chassis] plan to release java-chassis patch 1.2.1?
Posted by Willem Jiang <wi...@gmail.com>.
Yeah, we could release 1.2.1 for these important patches.
As the 1.2.1 is a patch release, my suggestion is we back port the
patches of bug fixing into the 1.2.x branch, and then cut the release
candidate.
@wjm do you mind mark the JIRAs of the bug with the fix version of
1.2.1, then we could start the cherry pick the patches into 1.2.x
branch.
Any thought?
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Sun, Apr 28, 2019 at 11:29 PM wjm wjm <zz...@gmail.com> wrote:
>
> there are some important fix for 1.2.0
>
>
> - when create microservice meta failed, will destroy failed meta, but
> leak to destroy related configuration resources, rarely happen, but it's a
> leak problem.
> - when log framework is log4j2, will leak some log4j2 marker object for
> every request, serious leak problem
> - default to disable inject x-cse-context from edge invoker, to
> avoid security issue problem
>
>
> other changes:
>
> - support consumer and producer return Optional type
> - inspector swagger online test support work with servlet having web
> root and servlet pattern
> - inspector support view configuration items
> - fix inspector swagger to html can not scroll problem
>
> do we plan to release a patch 1.2.1?