[GitHub] [spark] cloud-fan commented on a diff in pull request #37343: [SPARK-39923][SQL] Multiple query contexts in Spark exceptions

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37343:
URL: https://github.com/apache/spark/pull/37343#discussion_r934156009


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -103,7 +103,7 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase {
         toSQLType(from),
         toSQLType(to),
         toSQLId(columnName)),
-      context = None,
+      context = null,

Review Comment:
   I think we should never pass null as the context array to exception classes. If context is not available, we should pass `Array.empty`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org