[ofbiz-framework] 02/02: Improved: trivial changes in build.gradle and checkstyle.xml

[jl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git

commit 2ebbc51afd92b185a0be104380ebb6543bdc5810
Author: Jacques Le Roux <ja...@les7arts.com>
AuthorDate: Mon May 17 11:57:59 2021 +0200

    Improved: trivial changes in build.gradle and checkstyle.xml
---
 build.gradle                     | 2 +-
 config/checkstyle/checkstyle.xml | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/build.gradle b/build.gradle
index 840ed8b..f02e520 100644
--- a/build.gradle
+++ b/build.gradle
@@ -334,7 +334,7 @@ checkstyle {
     // ‘checkstyle’ tool present in the framework and in the official
     // plugins.
     tasks.checkstyleMain.maxErrors = 116
-    // Currently there are a lot of errors so we need to temporarily
+    // Currently there are still errors so we need to temporarily
     // hide them to avoid polluting the terminal output.
     showViolations = false
 }
diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml
index ebd2440..9bb4278 100644
--- a/config/checkstyle/checkstyle.xml
+++ b/config/checkstyle/checkstyle.xml
@@ -22,7 +22,10 @@ under the License.
           "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
           "https://checkstyle.org/dtds/configuration_1_3.dtd">
 <!-- This configuration corresponds to the OFBiz coding conventions
-     which are simply “Sun Coding Standards” + “150 characters line length” -->
+     which are basically “Sun Coding Standards”
+     + 150 characters line length
+     + NewlineAtEndOfFile value="lf_cr_crlf" />
+     -->
 <module name="Checker">
     <module name="BeforeExecutionExclusionFileFilter">
         <property name="fileNamePattern" value="module\-info\.java$"/>
@@ -31,7 +34,7 @@ under the License.
 
     <!-- General file conventions -->
     <module name="NewlineAtEndOfFile">
-        <property name="lineSeparator" value="lf" />
+        <property name="lineSeparator" value="lf_cr_crlf" />
     </module>
     <module name="FileTabCharacter"/>
     <module name="RegexpSingleline">