You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "lzdanski (via GitHub)" <gi...@apache.org> on 2023/08/07 15:11:46 UTC
[GitHub] [airflow] lzdanski opened a new pull request, #33176: Docs typo and capitalization fixes
lzdanski opened a new pull request, #33176:
URL: https://github.com/apache/airflow/pull/33176
Add code formatting and fix DAG capitalization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on a diff in pull request #33176: Docs typo and capitalization fixes
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #33176:
URL: https://github.com/apache/airflow/pull/33176#discussion_r1286029353
##########
docs/apache-airflow/howto/add-dag-tags.rst:
##########
@@ -28,7 +28,7 @@ The filter is saved in a cookie and can be reset by the reset button.
For example:
-In your Dag file, pass a list of tags you want to add to DAG object:
+In your DAG file, pass a list of tags you want to add to DAG object:
Review Comment:
nit: `add to the DAG object`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #33176: Docs typo and capitalization fixes
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #33176:
URL: https://github.com/apache/airflow/pull/33176#issuecomment-1668061912
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] lzdanski commented on a diff in pull request #33176: Docs typo and capitalization fixes
Posted by "lzdanski (via GitHub)" <gi...@apache.org>.
lzdanski commented on code in PR #33176:
URL: https://github.com/apache/airflow/pull/33176#discussion_r1286034662
##########
docs/apache-airflow/howto/add-dag-tags.rst:
##########
@@ -28,7 +28,7 @@ The filter is saved in a cookie and can be reset by the reset button.
For example:
-In your Dag file, pass a list of tags you want to add to DAG object:
+In your DAG file, pass a list of tags you want to add to DAG object:
Review Comment:
Thanks for catching! Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #33176: Docs typo and capitalization fixes
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham merged PR #33176:
URL: https://github.com/apache/airflow/pull/33176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #33176: Docs typo and capitalization fixes
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #33176:
URL: https://github.com/apache/airflow/pull/33176#issuecomment-1668167778
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #33176: Docs typo and capitalization fixes
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #33176:
URL: https://github.com/apache/airflow/pull/33176#issuecomment-1668169378
Thanks @lzdanski! Congrats on your first commit 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org