You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/29 05:54:00 UTC

[GitHub] [pulsar] lhotari edited a comment on issue #10433: NPE in broker: EntryImpl.getLength()

lhotari edited a comment on issue #10433:
URL: https://github.com/apache/pulsar/issues/10433#issuecomment-828958550


   > Though it won't disable the call to recycle, in where we're resetting the fields to nulls.
   
   @merlimat I guess the `data` field shouldn't be null in this case at all. EntryImpl.create is setting the `data` field by calling `EntryImpl.create(position, cachedData)` on line 112.
   
   https://github.com/apache/pulsar/blob/8ea4a39dc8bf6f2f23a160688bb70a80f6acfd4d/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryCacheImpl.java#L112-L115
   
   `EntryImpl.create`:
   
   https://github.com/apache/pulsar/blob/8ea4a39dc8bf6f2f23a160688bb70a80f6acfd4d/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryImpl.java#L81-L90
   
   The reported NPE is "impossible". :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org