You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Copilot (via GitHub)" <gi...@apache.org> on 2026/03/27 21:58:47 UTC
Re: [PR] [cleanup]Remove unused contrib/pinot-druid-benchmark directory [pinot]
Copilot commented on code in PR #18007:
URL: https://github.com/apache/pinot/pull/18007#discussion_r3003419484
##########
pinot-distribution/pinot-source-assembly.xml:
##########
@@ -53,7 +53,6 @@
<!-- Do not include docker, kubernetes related files -->
<exclude>kubernetes/**</exclude>
<exclude>docker/**</exclude>
- <exclude>contrib/pinot-druid-benchmark/**</exclude>
<exclude>thirdeye/**</exclude>
<exclude>thirdeye/**</exclude>
Review Comment:
The `thirdeye/**` pattern is excluded twice, which is redundant and makes the exclude list harder to maintain. Consider removing the duplicate entry so future changes only need to be made in one place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org