You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/07/04 13:39:26 UTC
[GitHub] flink pull request #4252: [FLINK-7074] [tm] Add entry point for the TaskMana...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4252
[FLINK-7074] [tm] Add entry point for the TaskManagerRunner
The entry point can be used by the standalone mode to run a TaskManager. Moreover, the
YarnTaskExecutorRunner now reuses some of the start up logic of the TaskManagerRunner.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink addTaskManagerEntrypoint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4252
----
commit dbd9a5d8fa3d6f3b20ba48484b9098a7fe280403
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-04T13:01:18Z
[FLINK-7074] [tm] Add entry point for the TaskManagerRunner
The entry point can be used by the standalone mode to run a TaskManager. Moreover, the
YarnTaskExecutorRunner now reuses some of the start up logic of the TaskManagerRunner.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4252: [FLINK-7074] [tm] Add entry point for the TaskManagerRunn...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4252
Thanks for the review @zentol. I addressed your comment. Merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4252: [FLINK-7074] [tm] Add entry point for the TaskMana...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4252: [FLINK-7074] [tm] Add entry point for the TaskManagerRunn...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4252
but....I didn't make a full review. I just scanned over it and found the oddity in the dependency...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4252: [FLINK-7074] [tm] Add entry point for the TaskMana...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4252#discussion_r125617193
--- Diff: flink-runtime/pom.xml ---
@@ -117,6 +117,16 @@ under the License.
</dependency>
<dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
--- End diff --
I found a solution by manually setting the dependencies to scope compile within IntelliJ. For the others who run into the same problem you can do this under: Project structure --> Modules --> Dependency tab.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4252: [FLINK-7074] [tm] Add entry point for the TaskMana...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4252#discussion_r125492494
--- Diff: flink-runtime/pom.xml ---
@@ -117,6 +117,16 @@ under the License.
</dependency>
<dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
--- End diff --
IIRC we explicitly removed these dependencies so that other logging frameworks can be plugged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4252: [FLINK-7074] [tm] Add entry point for the TaskMana...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4252#discussion_r125503520
--- Diff: flink-runtime/pom.xml ---
@@ -117,6 +117,16 @@ under the License.
</dependency>
<dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
--- End diff --
The problem I had was that I couldn't start the `TaskManagerRunner#main` from within Intellij, because the class `org.apache.log4j.Level` could not be found. If I'm not mistaken, then we filter out the log4j dependencies when building the dist packages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4252: [FLINK-7074] [tm] Add entry point for the TaskMana...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4252#discussion_r125618495
--- Diff: flink-runtime/pom.xml ---
@@ -117,6 +117,16 @@ under the License.
</dependency>
<dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
--- End diff --
For the sake of completeness, here is also the corresponding IntelliJ issue: https://youtrack.jetbrains.com/issue/IDEA-107048
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---