You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/02 21:55:59 UTC

[GitHub] [spark] shivsood commented on issue #25211: [WIP][SPARK-24907][SQL] DataSourceV2 based connector for JDBC

shivsood commented on issue #25211: [WIP][SPARK-24907][SQL] DataSourceV2 based connector for JDBC
URL: https://github.com/apache/spark/pull/25211#issuecomment-517855415
 
 
   Have a first draft of DataSourceV2 based JDBC connector available now ( PR#25211) . The goal was a MVP implementation with support for batch read/write. I am looking forward for your review comments to help guide direction. Note that i am still understanding/addressing some issues. The plan, status issues is capture in the Readme.md
   
   Summary of changes
   - V2 connector changes are under under sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc. The implementation heavily reuses infra provided by JDBCUtils.
   - JDBCUtils(sql/core/../datasources/jdbc/JdbcUtils.scala) file is refactored ( for few functions) to suite V2 needs.
   - E2E test cases are in external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MsSqlServerIntegrationSuite.scala
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org