Re: [PR] [SPARK-49308][CONNECT] Support UserDefinedAggregateFunction in Spark Connect Scala Client [spark]

["eejbyfeldt (via GitHub)" <gi...@apache.org>]

eejbyfeldt commented on code in PR #49785:
URL: https://github.com/apache/spark/pull/49785#discussion_r2093569759


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala:
##########
@@ -406,14 +406,20 @@ object DeserializerBuildHelper {
         NewInstance(cls, arguments, Nil, propagateNull = false, dt, outerPointerGetter))
 
     case AgnosticEncoders.RowEncoder(fields) =>
+      val isExternalRow = !path.dataType.isInstanceOf[StructType]

Review Comment:
   Is it really safe to call `dataType` here? The `path` expression might not be resolved and then this will throw an exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org