You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by blrunner <gi...@git.apache.org> on 2014/08/19 05:34:34 UTC
[GitHub] tajo pull request: TAJO-1011: EvalTreeUtil::isJoinQual need to han...
GitHub user blrunner opened a pull request:
https://github.com/apache/tajo/pull/122
TAJO-1011: EvalTreeUtil::isJoinQual need to handle other join conditions.
TAJO-1011: EvalTreeUtil::isJoinQual need to handle other join conditions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blrunner/tajo TAJO-1011
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #122
----
commit 7c98709f0fcb06dfb675acae3d6489a6126f55b5
Author: jinossy <ji...@gmail.com>
Date: 2014-08-06T08:43:35Z
TAJO-995: HiveMetaStoreClient wrapper should retry the connection
commit 415d0867ae4a4543f47360294bead1fc7f41e292
Author: Jaehwa Jung <bl...@apache.org>
Date: 2014-08-10T06:07:24Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo
commit 7a7b4fd26f61df89cacdb4fc41faf9c2abe456b2
Author: Jaehwa Jung <bl...@apache.org>
Date: 2014-08-11T02:28:48Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo
commit 45f5ed3adba931f4706f26dda1d3c03240ee11d3
Author: Jaehwa Jung <bl...@apache.org>
Date: 2014-08-11T05:40:25Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo
commit aa01e83859ef553ac4eb90c1678e3bc6be20c6c9
Author: Jaehwa Jung <bl...@apache.org>
Date: 2014-08-18T09:56:24Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo
commit 95f08323e5a46d550535f7b2f8f9deb5801a6338
Author: Jaehwa Jung <bl...@apache.org>
Date: 2014-08-19T03:30:14Z
Merge branch 'master' of https://github.com/blrunner/tajo into HEAD
commit 82892eeea6000133db134b75556411da30f9f2ef
Author: Jaehwa Jung <bl...@apache.org>
Date: 2014-08-19T03:32:50Z
TAJO-1011: EvalTreeUtil::isJoinQual need to handle other join conditions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1011: EvalTreeUtil::isJoinQual need to han...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/122#issuecomment-52618777
+1
The patch looks good to me. Ship it. As you already mentioned in the change, this change still misunderstand an comparison expression of complex expressions which includes one column of the same table respectively. I'll submit the patch for it. The current patch will fix the current unit test failures now.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1011: EvalTreeUtil::isJoinQual need to han...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/122#issuecomment-52634398
Hi @hyunsik.
Thank you for your review. I agree with you, we need to handle this issue continuously.
P.S I've just committed it to the master branch. :)
Cheers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1011: EvalTreeUtil::isJoinQual need to han...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner closed the pull request at:
https://github.com/apache/tajo/pull/122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---