You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mike Drob (JIRA)" <ji...@apache.org> on 2017/10/16 20:32:00 UTC

[jira] [Commented] (HBASE-18893) shell 'alter' command no longer distinguishes column add/modify/delete

    [ https://issues.apache.org/jira/browse/HBASE-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206557#comment-16206557 ] 

Mike Drob commented on HBASE-18893:
-----------------------------------

Discussed this with [~appy], he suggested that we can manually examine the new table descriptor and then call preAddColumn/preDeleteColumn/etc as appropriate and still keep a single call to modifyTable in the submit procedure. An interesting problem comes up with the return values of preXXX methods - preModifyTable is void so there is no return false to bypass chance here, but the other preXXX methods are boolean typed. Do we need to respect their ability to bypass or not?

[~Apache9], [~apurtell], [~stack] - this is related to the discussion you were already having, tagging y'all for visibility.

> shell 'alter' command no longer distinguishes column add/modify/delete
> ----------------------------------------------------------------------
>
>                 Key: HBASE-18893
>                 URL: https://issues.apache.org/jira/browse/HBASE-18893
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: Mike Drob
>
> After HBASE-15641 all 'alter' commands go through a single modifyTable call at the end, so we no longer can easily distinguish add, modify, and delete column events. This potentially affects coprocessors that needed the update notifications for new or removed columns.
> Let's let the shell still make separate behaviour calls like it did before without undoing the batching that seems pretty useful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)