You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "TruthIsNear (via GitHub)" <gi...@apache.org> on 2023/08/01 09:32:26 UTC
[GitHub] [airflow] TruthIsNear opened a new pull request, #32999: Fix DAG-level permissions disappearance on DAG sync
TruthIsNear opened a new pull request, #32999:
URL: https://github.com/apache/airflow/pull/32999
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Closes: #32839
Adds back the code that was removed in #30340
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #32999: Fix DAG-level permissions disappearance on DAG sync
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #32999: Fix DAG-level permissions disappearance on DAG sync
URL: https://github.com/apache/airflow/pull/32999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32999: Fix DAG-level permissions disappearance on DAG sync
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32999:
URL: https://github.com/apache/airflow/pull/32999#issuecomment-1666858383
I rebased it and marked is as 2.7.0. Indeed the #30340 removed syncing where it was still needed and reverting the change seems to solve the problem.
I think this is a blocker for people who use it and want to migrate so having it fixed in 2.7.0 would be great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32999: Fix DAG-level permissions disappearance on DAG sync
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32999:
URL: https://github.com/apache/airflow/pull/32999#issuecomment-1692278185
Closing in favour of just merged https://github.com/apache/airflow/pull/33632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] TruthIsNear commented on pull request #32999: Fix DAG-level permissions disappearance on DAG sync
Posted by "TruthIsNear (via GitHub)" <gi...@apache.org>.
TruthIsNear commented on PR #32999:
URL: https://github.com/apache/airflow/pull/32999#issuecomment-1660087319
> How does this affect the issue #30340 is supposed to solve?
Seems like this PR does introduce that issue back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32999: Fix DAG-level permissions disappearance on DAG sync
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32999:
URL: https://github.com/apache/airflow/pull/32999#issuecomment-1666861732
I am not sure however if that one is just a band-aid.
Can someone - who knows how the logic of dag permissions syncing was supposed to work? I would like to understand it, because it seems that almost no-one knows how it should work and it is certainly not documented. A slimple logical description of what should happen here might be very useful. I am hppy to take a closer look and try to do it properly. but I need some guidance. I've never touched this part of code and it's a bit of mistery for me on how it **should** work - but I ema willing to learn @kaxil @jedcunningham @uranusjr. Maybe a birds eye view on that one ??
I think we dropped a ball on that one for 2.6.2 and mostly because we had too little expert knowledge there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #32999: Fix DAG-level permissions disappearance on DAG sync
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #32999:
URL: https://github.com/apache/airflow/pull/32999#issuecomment-1659937535
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32999: Fix DAG-level permissions disappearance on DAG sync
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32999:
URL: https://github.com/apache/airflow/pull/32999#issuecomment-1691017332
I thin @SamWheating #33632 solution is a better solution. Closing this one in favour of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #32999: Fix DAG-level permissions disappearance on DAG sync
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #32999:
URL: https://github.com/apache/airflow/pull/32999#issuecomment-1659962048
How does this affect the issue #30340 is supposed to solve?
Also cc @huymq1710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org