You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Revolyssup (via GitHub)" <gi...@apache.org> on 2023/12/03 16:08:47 UTC
[PR] fix: upgrade etcd-adapter [apisix-ingress-controller]
Revolyssup opened a new pull request, #2078:
URL: https://github.com/apache/apisix-ingress-controller/pull/2078
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
fixes #2076
<!-- Please delete options that are not relevant. -->
TESTS TO BE ADDED
<!-- Select all the options from below that matches the type your PR best -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- [ ] Documentation
- [ ] Refactor
- [ ] Chore
- [ ] CI/CD or Tests
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: upgrade etcd-adapter [apisix-ingress-controller]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2078:
URL: https://github.com/apache/apisix-ingress-controller/pull/2078#issuecomment-1837527625
## [Codecov](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/2078?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`9b3b605`)](https://app.codecov.io/gh/apache/apisix-ingress-controller/commit/9b3b60597b2fa327fec28c00497666a9eff5fb52?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 37.12% compared to head [(`05e607c`)](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/2078?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 37.12%.
> :exclamation: Current head 05e607c differs from pull request most recent head 2e430e7. Consider uploading reports for the commit 2e430e7 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2078 +/- ##
=======================================
Coverage 37.12% 37.12%
=======================================
Files 93 93
Lines 7886 7886
=======================================
Hits 2928 2928
Misses 4568 4568
Partials 390 390
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/2078?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: upgrade etcd-adapter [apisix-ingress-controller]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on code in PR #2078:
URL: https://github.com/apache/apisix-ingress-controller/pull/2078#discussion_r1415589923
##########
test/e2e/suite-features/external-service.go:
##########
@@ -159,18 +155,18 @@ spec:
Status(http.StatusOK)
}
- PhaseValidateRouteAccessCode := func(s *scaffold.Scaffold, upstreamId string, code int) {
- routes, err := s.ListApisixRoutes()
- assert.Nil(ginkgo.GinkgoT(), err)
- assert.Len(ginkgo.GinkgoT(), routes, 1, "route count")
- assert.Equal(ginkgo.GinkgoT(), upstreamId, routes[0].UpstreamId)
+ // PhaseValidateRouteAccessCode := func(s *scaffold.Scaffold, upstreamId string, code int) {
+ // routes, err := s.ListApisixRoutes()
+ // assert.Nil(ginkgo.GinkgoT(), err)
+ // assert.Len(ginkgo.GinkgoT(), routes, 1, "route count")
+ // assert.Equal(ginkgo.GinkgoT(), upstreamId, routes[0].UpstreamId)
- _ = s.NewAPISIXClient().GET("/ip").
- WithHeader("Host", "httpbin.org").
- WithHeader("X-Foo", "bar").
- Expect().
- Status(code)
- }
+ // _ = s.NewAPISIXClient().GET("/ip").
+ // WithHeader("Host", "httpbin.org").
+ // WithHeader("X-Foo", "bar").
+ // Expect().
+ // Status(code)
+ // }
Review Comment:
why comment out instead of removing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: upgrade etcd-adapter [apisix-ingress-controller]
Posted by "Revolyssup (via GitHub)" <gi...@apache.org>.
Revolyssup merged PR #2078:
URL: https://github.com/apache/apisix-ingress-controller/pull/2078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: upgrade etcd-adapter [apisix-ingress-controller]
Posted by "Revolyssup (via GitHub)" <gi...@apache.org>.
Revolyssup commented on code in PR #2078:
URL: https://github.com/apache/apisix-ingress-controller/pull/2078#discussion_r1415594566
##########
test/e2e/suite-features/external-service.go:
##########
@@ -159,18 +155,18 @@ spec:
Status(http.StatusOK)
}
- PhaseValidateRouteAccessCode := func(s *scaffold.Scaffold, upstreamId string, code int) {
- routes, err := s.ListApisixRoutes()
- assert.Nil(ginkgo.GinkgoT(), err)
- assert.Len(ginkgo.GinkgoT(), routes, 1, "route count")
- assert.Equal(ginkgo.GinkgoT(), upstreamId, routes[0].UpstreamId)
+ // PhaseValidateRouteAccessCode := func(s *scaffold.Scaffold, upstreamId string, code int) {
+ // routes, err := s.ListApisixRoutes()
+ // assert.Nil(ginkgo.GinkgoT(), err)
+ // assert.Len(ginkgo.GinkgoT(), routes, 1, "route count")
+ // assert.Equal(ginkgo.GinkgoT(), upstreamId, routes[0].UpstreamId)
- _ = s.NewAPISIXClient().GET("/ip").
- WithHeader("Host", "httpbin.org").
- WithHeader("X-Foo", "bar").
- Expect().
- Status(code)
- }
+ // _ = s.NewAPISIXClient().GET("/ip").
+ // WithHeader("Host", "httpbin.org").
+ // WithHeader("X-Foo", "bar").
+ // Expect().
+ // Status(code)
+ // }
Review Comment:
might be helpful in future
##########
test/e2e/suite-features/external-service.go:
##########
@@ -159,18 +155,18 @@ spec:
Status(http.StatusOK)
}
- PhaseValidateRouteAccessCode := func(s *scaffold.Scaffold, upstreamId string, code int) {
- routes, err := s.ListApisixRoutes()
- assert.Nil(ginkgo.GinkgoT(), err)
- assert.Len(ginkgo.GinkgoT(), routes, 1, "route count")
- assert.Equal(ginkgo.GinkgoT(), upstreamId, routes[0].UpstreamId)
+ // PhaseValidateRouteAccessCode := func(s *scaffold.Scaffold, upstreamId string, code int) {
+ // routes, err := s.ListApisixRoutes()
+ // assert.Nil(ginkgo.GinkgoT(), err)
+ // assert.Len(ginkgo.GinkgoT(), routes, 1, "route count")
+ // assert.Equal(ginkgo.GinkgoT(), upstreamId, routes[0].UpstreamId)
- _ = s.NewAPISIXClient().GET("/ip").
- WithHeader("Host", "httpbin.org").
- WithHeader("X-Foo", "bar").
- Expect().
- Status(code)
- }
+ // _ = s.NewAPISIXClient().GET("/ip").
+ // WithHeader("Host", "httpbin.org").
+ // WithHeader("X-Foo", "bar").
+ // Expect().
+ // Status(code)
+ // }
Review Comment:
not being used right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org