You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by alinnert <gi...@git.apache.org> on 2014/04/14 16:34:32 UTC

[GitHub] cordova-plugin-inappbrowser pull request: window.open(url, '_syste...

GitHub user alinnert opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/39

    window.open(url, '_system') does work now

    Checking the variable `featString` for null value.
    If third parameter of `window.open()` is not used, the method fails at `featString.Split(',')` because featString is null.
    This was the reason why `window.open()` with target `_system` did not work on Windows Phone.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alinnert/cordova-plugin-inappbrowser patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #39
    
----
commit 699bd72724adc37e4e38874ecd02ec578014a38b
Author: Andreas Linnert <ps...@live.de>
Date:   2014-04-14T14:32:29Z

    window.open(url, '_system') does work now
    
    Checking the variable "featString" for null value.
    If third parameter of window.open() is not used, the method fails at featString.Split(',') because featString is null.
    This was the reason why window.open() with target '_system' did not work on Windows Phone.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: window.open(url, '_syste...

Posted by alinnert <gi...@git.apache.org>.

Github user alinnert commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/39#issuecomment-40447640
  
    Ah, I see. Then I use the mentioned solution. Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: window.open(url, '_syste...

Posted by alinnert <gi...@git.apache.org>.

Github user alinnert closed the pull request at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/39


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: window.open(url, '_syste...

Posted by purplecabbage <gi...@git.apache.org>.

Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/39#issuecomment-40398079
  
    This has been addressed in JS code [1] , 
    and is a native patch is also part of pull-req #38 
    
    Expect these changes to land in the next published version of IAB or plugman install from source.
    This pull request should be closed.
    
    Thanks,
      Jesse
    
    [1] https://github.com/apache/cordova-plugin-inappbrowser/commit/bddf86c3cefd9d787876d15e771beb499e43eb2f



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---