You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/27 01:37:21 UTC
[GitHub] [shardingsphere] jingshanglu opened a new pull request, #17985: Improve the autoCommit feature
jingshanglu opened a new pull request, #17985:
URL: https://github.com/apache/shardingsphere/pull/17985
Changes proposed in this pull request:
- when autocommit=0, only DDL/DML will auto open a new tranasction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #17985: Improve the autoCommit feature
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17985:
URL: https://github.com/apache/shardingsphere/pull/17985#issuecomment-1139217157
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17985?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17985](https://codecov.io/gh/apache/shardingsphere/pull/17985?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9066243) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5f5253ef08adde8ab1ed5e7c0fa37a9d4e700be3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5f5253e) will **increase** coverage by `0.05%`.
> The diff coverage is `48.32%`.
> :exclamation: Current head 9066243 differs from pull request most recent head 313054e. Consider uploading reports for the commit 313054e to get more accurate results
```diff
@@ Coverage Diff @@
## master #17985 +/- ##
============================================
+ Coverage 58.91% 58.97% +0.05%
- Complexity 2140 2142 +2
============================================
Files 3639 3642 +3
Lines 54020 54052 +32
Branches 9186 9189 +3
============================================
+ Hits 31828 31878 +50
+ Misses 19480 19461 -19
- Partials 2712 2713 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/core/common/CommonDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/17985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvY29yZS9jb21tb24vQ29tbW9uRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ueryable/ExportDatabaseConfigurationStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JhbC9jb21tb24vcXVlcnlhYmxlL0V4cG9ydERhdGFiYXNlQ29uZmlndXJhdGlvblN0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [...l/common/queryable/ShowTableMetadataStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JhbC9jb21tb24vcXVlcnlhYmxlL1Nob3dUYWJsZU1ldGFkYXRhU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...tatement/rql/show/CountDatabaseRulesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L0NvdW50RGF0YWJhc2VSdWxlc1N0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [...ser/statement/rql/show/ShowResourcesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L1Nob3dSZXNvdXJjZXNTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../parser/statement/rql/show/ShowRulesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L1Nob3dSdWxlc1N0YXRlbWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ement/rql/show/ShowRulesUsedResourceStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L1Nob3dSdWxlc1VzZWRSZXNvdXJjZVN0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [...atement/rql/show/ShowUnusedResourcesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvc3RhdGVtZW50L3JxbC9zaG93L1Nob3dVbnVzZWRSZXNvdXJjZXNTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...core/DatabaseDiscoveryDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/17985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9wYXJzZXIvY29yZS9EYXRhYmFzZURpc2NvdmVyeURpc3RTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...encrypt/metadata/EncryptSchemaMetaDataBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/17985/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdFNjaGVtYU1ldGFEYXRhQnVpbGRlci5qYXZh) | `91.66% <ø> (ø)` | |
| ... and [177 more](https://codecov.io/gh/apache/shardingsphere/pull/17985/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17985?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17985?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b89cc80...313054e](https://codecov.io/gh/apache/shardingsphere/pull/17985?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #17985: Improve the autoCommit feature
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #17985:
URL: https://github.com/apache/shardingsphere/pull/17985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org