You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/11/08 20:11:54 UTC

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #16729: [NumPy][TVM] NumPy Unary Operator Using TVM Infra

reminisce commented on a change in pull request #16729: [NumPy][TVM] NumPy Unary Operator Using TVM Infra
URL: https://github.com/apache/incubator-mxnet/pull/16729#discussion_r344348461
 
 

 ##########
 File path: contrib/tvmop/utils.py
 ##########
 @@ -20,7 +20,16 @@
 
 AllTypes = ["float32", "float64", "float16", "uint8", "int8", "int32", "int64"]
 RealTypes = ["float32", "float64", "float16"]
-
+acc_type_resolver = {
 
 Review comment:
   `acc` usually means accumulation for reduce-like ops. Seems here it's only for unary element-wise ops. Shall we rename to something like `unary_result_type` to echo `np.result_type`? Also, I think it would be better to implement this as a function, instead of using a dict.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services