You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2019/05/08 20:14:46 UTC
[impala] branch master updated: IMPALA-8527: prune maven repo
dependencies
This is an automated email from the ASF dual-hosted git repository.
tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 4c6ac15 IMPALA-8527: prune maven repo dependencies
4c6ac15 is described below
commit 4c6ac151ef2c6efac8a8a3d02c342334bf9d688c
Author: Tim Armstrong <ta...@cloudera.com>
AuthorDate: Wed May 8 00:26:57 2019 -0700
IMPALA-8527: prune maven repo dependencies
We transitively pull in references to repository.apache.org,
which in turn means we'll go looking for most of our dependencies
there. Downloading from repository.apache.org occasionally hangs,
so there's a high probability of a build getting stuck.
I was able to disable repository.apache.org entirely - the same packages
are available from other repositories that we don't see the same
issues with.
Locating snapshot versions is very chatty - we reach out to
mvnrepository.com and apache.org repeatedly, but I don't think
we actually need to consume any snapshots from them. So I
tried to minimise the number of repositories that we'll consume
snapshots from - I think we only intend to download snapshots
from the CDH repo.
Also remove the plugin snapshots repository. We historically
needed it because we used a snapshot version of the cup plugin,
but that was fixed by IMPALA-3418. Otherwise depending on plugin
snapshots seems like a bad idea.
Change-Id: I08e1f1b7d7742edd61179ee52b5e268c3b4dc61d
Reviewed-on: http://gerrit.cloudera.org:8080/13279
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
impala-parent/pom.xml | 47 ++++++++++++++++++++++++++++++++++++++---------
1 file changed, 38 insertions(+), 9 deletions(-)
diff --git a/impala-parent/pom.xml b/impala-parent/pom.xml
index a6bbbd9..e7c08fc 100644
--- a/impala-parent/pom.xml
+++ b/impala-parent/pom.xml
@@ -64,6 +64,11 @@ under the License.
</properties>
<repositories>
+ <!--
+ Blacklist Apache repositories that tend to cause timeouts - see IMPALA-8516.
+ These are pulled in via transitive deps, e.g. Sentry. Other repositories contain
+ mirrored versions of these dependencies but don't have the same timeout issues.
+ -->
<repository>
<id>apache.snapshots</id>
<name>Apache Development Snapshot Repository</name>
@@ -72,7 +77,31 @@ under the License.
<enabled>false</enabled>
</releases>
<snapshots>
- <enabled>true</enabled>
+ <enabled>false</enabled>
+ </snapshots>
+ </repository>
+ <repository>
+ <id>apache</id>
+ <name>Apache Repository</name>
+ <url>https://repository.apache.org/content/repositories/</url>
+ <releases>
+ <enabled>false</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ </repository>
+ <repository>
+ <!--
+ This is a transitive dependency from Sentry. Disable downloading snapshots from here
+ since we only want to consume actual releases and we can save Maven from reaching
+ out to this repo unnecessarily to look for snapshot versions.
+ -->
+ <id>glassfish-repo-archive.repo</id>
+ <name>Glassfish repository - Transitive from Sentry</name>
+ <url>https://mvnrepository.com/artifact/org.glassfish/javax.el/</url>
+ <snapshots>
+ <enabled>false</enabled>
</snapshots>
</repository>
<repository>
@@ -112,6 +141,10 @@ under the License.
</snapshots>
</repository>
<repository>
+ <!--
+ The Maven repository for the CDP build identified by CDP_BUILD_NUMBER.
+ CDP does not use maven SNAPSHOT versions - every build has a version number.
+ -->
<id>impala.cdp.repo</id>
<url>https://${env.IMPALA_TOOLCHAIN_HOST}/build/cdp_components/${env.CDP_BUILD_NUMBER}/maven</url>
<name>Impala CDP Repository</name>
@@ -120,6 +153,10 @@ under the License.
</snapshots>
</repository>
<repository>
+ <!--
+ The Maven repository for the CDH build identified by CDH_BUILD_NUMBER.
+ CDH uses maven SNAPSHOT versions for non-released versions of components.
+ -->
<id>impala.cdh.repo</id>
<url>https://${env.IMPALA_TOOLCHAIN_HOST}/build/cdh_components/${env.CDH_BUILD_NUMBER}/maven</url>
<name>Impala CDH Repository</name>
@@ -154,14 +191,6 @@ under the License.
<enabled>false</enabled>
</snapshots>
</pluginRepository>
- <pluginRepository>
- <id>cloudera.snapshot.repo</id>
- <url>https://repository.cloudera.com/content/repositories/snapshots</url>
- <name>Cloudera Snapshot Repository</name>
- <snapshots>
- <enabled>true</enabled>
- </snapshots>
- </pluginRepository>
</pluginRepositories>
</project>