You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Kent Tong (JIRA)" <ji...@apache.org> on 2007/09/08 17:38:29 UTC

[jira] Created: (WICKET-945) WicketTester requiring itself to be serializable

WicketTester requiring itself to be serializable
------------------------------------------------

                 Key: WICKET-945
                 URL: https://issues.apache.org/jira/browse/WICKET-945
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.0-beta3
            Reporter: Kent Tong


Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.

public final Panel startPanel(final Class panelClass)
	{
		return (Panel)startPage(new ITestPageSource()
		{
			private static final long serialVersionUID = 1L;

			public Page getTestPage()
			{
				return new DummyPanelPage(new TestPanelSource()
				{
					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-945) WicketTester requiring itself to be serializable

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-945:
--------------------------------------

    Fix Version/s:     (was: 1.3.0-rc2)
                   1.3.0-rc3

> WicketTester requiring itself to be serializable
> ------------------------------------------------
>
>                 Key: WICKET-945
>                 URL: https://issues.apache.org/jira/browse/WICKET-945
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Kent Tong
>             Fix For: 1.3.0-rc3
>
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
> 	{
> 		return (Panel)startPage(new ITestPageSource()
> 		{
> 			private static final long serialVersionUID = 1L;
> 			public Page getTestPage()
> 			{
> 				return new DummyPanelPage(new TestPanelSource()
> 				{
> 					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-945) WicketTester requiring itself to be serializable

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581433#action_12581433 ] 

Frank Bille Jensen commented on WICKET-945:
-------------------------------------------

For now we only have this: http://cwiki.apache.org/WICKET/wicket-14-wish-list.html#Wicket1.4WishList-MakeWicketTesterafirstclasscitizen

> WicketTester requiring itself to be serializable
> ------------------------------------------------
>
>                 Key: WICKET-945
>                 URL: https://issues.apache.org/jira/browse/WICKET-945
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Kent Tong
>             Fix For: 1.5-M1
>
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
> 	{
> 		return (Panel)startPage(new ITestPageSource()
> 		{
> 			private static final long serialVersionUID = 1L;
> 			public Page getTestPage()
> 			{
> 				return new DummyPanelPage(new TestPanelSource()
> 				{
> 					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-945) WicketTester requiring itself to be serializable

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-945:
--------------------------------------

    Fix Version/s:     (was: 1.3.0-rc3)
                   1.3.1

> WicketTester requiring itself to be serializable
> ------------------------------------------------
>
>                 Key: WICKET-945
>                 URL: https://issues.apache.org/jira/browse/WICKET-945
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Kent Tong
>             Fix For: 1.3.1
>
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
> 	{
> 		return (Panel)startPage(new ITestPageSource()
> 		{
> 			private static final long serialVersionUID = 1L;
> 			public Page getTestPage()
> 			{
> 				return new DummyPanelPage(new TestPanelSource()
> 				{
> 					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-945) WicketTester requiring itself to be serializable

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-945:
--------------------------------------

    Fix Version/s:     (was: 1.3.0-rc1)
                   1.3.0-rc2

> WicketTester requiring itself to be serializable
> ------------------------------------------------
>
>                 Key: WICKET-945
>                 URL: https://issues.apache.org/jira/browse/WICKET-945
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Kent Tong
>             Fix For: 1.3.0-rc2
>
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
> 	{
> 		return (Panel)startPage(new ITestPageSource()
> 		{
> 			private static final long serialVersionUID = 1L;
> 			public Page getTestPage()
> 			{
> 				return new DummyPanelPage(new TestPanelSource()
> 				{
> 					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-945) WicketTester requiring itself to be serializable

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531131 ] 

Juergen Donnerstag commented on WICKET-945:
-------------------------------------------

I changed the loglevel to info, run all test and checked the output. But I didn't find any WicketNotSerializableException. Could it be the problem was fixed with wicket-727?

> WicketTester requiring itself to be serializable
> ------------------------------------------------
>
>                 Key: WICKET-945
>                 URL: https://issues.apache.org/jira/browse/WICKET-945
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Kent Tong
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
> 	{
> 		return (Panel)startPage(new ITestPageSource()
> 		{
> 			private static final long serialVersionUID = 1L;
> 			public Page getTestPage()
> 			{
> 				return new DummyPanelPage(new TestPanelSource()
> 				{
> 					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-945) WicketTester requiring itself to be serializable

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-945.
----------------------------------

    Resolution: Invalid

must have already been fixed.

looking at startPanel() code:

return (Panel)startPage(new ITestPageSource()
		{
			private static final long serialVersionUID = 1L;

			public Page getTestPage()
			{
				return new DummyPanelPage(testPanelSource);
			}
		}).get(DummyPanelPage.TEST_PANEL_ID);

the page returned is not anonymous so it wont carry a reference to anything.

> WicketTester requiring itself to be serializable
> ------------------------------------------------
>
>                 Key: WICKET-945
>                 URL: https://issues.apache.org/jira/browse/WICKET-945
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Kent Tong
>             Fix For: 1.5-M2
>
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
> 	{
> 		return (Panel)startPage(new ITestPageSource()
> 		{
> 			private static final long serialVersionUID = 1L;
> 			public Page getTestPage()
> 			{
> 				return new DummyPanelPage(new TestPanelSource()
> 				{
> 					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-945) WicketTester requiring itself to be serializable

Posted by "Kent Tong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581313#action_12581313 ] 

Kent Tong commented on WICKET-945:
----------------------------------

I've heard this redesign thing a few times. Is there a wiki page showing the major directions of the redesign?

> WicketTester requiring itself to be serializable
> ------------------------------------------------
>
>                 Key: WICKET-945
>                 URL: https://issues.apache.org/jira/browse/WICKET-945
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Kent Tong
>             Fix For: 1.5-M1
>
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
> 	{
> 		return (Panel)startPage(new ITestPageSource()
> 		{
> 			private static final long serialVersionUID = 1L;
> 			public Page getTestPage()
> 			{
> 				return new DummyPanelPage(new TestPanelSource()
> 				{
> 					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-945) WicketTester requiring itself to be serializable

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-945:
--------------------------------------

    Fix Version/s:     (was: 1.3.3)
                   1.5-M1

Part of the bigger redesign of wickettester

> WicketTester requiring itself to be serializable
> ------------------------------------------------
>
>                 Key: WICKET-945
>                 URL: https://issues.apache.org/jira/browse/WICKET-945
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Kent Tong
>             Fix For: 1.5-M1
>
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
> 	{
> 		return (Panel)startPage(new ITestPageSource()
> 		{
> 			private static final long serialVersionUID = 1L;
> 			public Page getTestPage()
> 			{
> 				return new DummyPanelPage(new TestPanelSource()
> 				{
> 					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-945) WicketTester requiring itself to be serializable

Posted by "Kent Tong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532023 ] 

Kent Tong commented on WICKET-945:
----------------------------------

At the risk of stating the obvious, did you call startPanel() in your test?

> WicketTester requiring itself to be serializable
> ------------------------------------------------
>
>                 Key: WICKET-945
>                 URL: https://issues.apache.org/jira/browse/WICKET-945
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Kent Tong
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
> 	{
> 		return (Panel)startPage(new ITestPageSource()
> 		{
> 			private static final long serialVersionUID = 1L;
> 			public Page getTestPage()
> 			{
> 				return new DummyPanelPage(new TestPanelSource()
> 				{
> 					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-945) WicketTester requiring itself to be serializable

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-945:
---------------------------------

    Fix Version/s: 1.5-M2
                       (was: 1.5-M1)

> WicketTester requiring itself to be serializable
> ------------------------------------------------
>
>                 Key: WICKET-945
>                 URL: https://issues.apache.org/jira/browse/WICKET-945
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Kent Tong
>             Fix For: 1.5-M2
>
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
> 	{
> 		return (Panel)startPage(new ITestPageSource()
> 		{
> 			private static final long serialVersionUID = 1L;
> 			public Page getTestPage()
> 			{
> 				return new DummyPanelPage(new TestPanelSource()
> 				{
> 					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-945) WicketTester requiring itself to be serializable

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-945:
--------------------------------------

    Fix Version/s:     (was: 1.3.1)
                   1.3.2

> WicketTester requiring itself to be serializable
> ------------------------------------------------
>
>                 Key: WICKET-945
>                 URL: https://issues.apache.org/jira/browse/WICKET-945
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Kent Tong
>             Fix For: 1.3.2
>
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
> 	{
> 		return (Panel)startPage(new ITestPageSource()
> 		{
> 			private static final long serialVersionUID = 1L;
> 			public Page getTestPage()
> 			{
> 				return new DummyPanelPage(new TestPanelSource()
> 				{
> 					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-945) WicketTester requiring itself to be serializable

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-945:
--------------------------------------

    Fix Version/s:     (was: 1.3.2)
                   1.3.3

> WicketTester requiring itself to be serializable
> ------------------------------------------------
>
>                 Key: WICKET-945
>                 URL: https://issues.apache.org/jira/browse/WICKET-945
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Kent Tong
>             Fix For: 1.3.3
>
>
> Similar to https://issues.apache.org/jira/browse/WICKET-727, in BaseWicketTester, it creates objects of anonymous classes as pages (DummyPanelPage). By definition, they refer to the tester itself and will try to drag it in when they're serialized.
> public final Panel startPanel(final Class panelClass)
> 	{
> 		return (Panel)startPage(new ITestPageSource()
> 		{
> 			private static final long serialVersionUID = 1L;
> 			public Page getTestPage()
> 			{
> 				return new DummyPanelPage(new TestPanelSource()
> 				{
> 					private static final long serialVersionUID = 1L;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.