You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/25 08:28:28 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #6270: Python-legacy: Pin flake8
Fokko opened a new pull request, #6270:
URL: https://github.com/apache/iceberg/pull/6270
Flake8 6.0.0 has been released, and this breaks the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] XN137 commented on a diff in pull request #6270: Python-legacy: Pin flake8
Posted by GitBox <gi...@apache.org>.
XN137 commented on code in PR #6270:
URL: https://github.com/apache/iceberg/pull/6270#discussion_r1032407392
##########
python_legacy/tox.ini:
##########
@@ -49,7 +49,7 @@ commands =
basepython = python3
skip_install = true
deps =
- flake8>=3.8.4
+ flake8==5.0.4
flake8-import-order>=0.9
Review Comment:
should we pin this as well maybe, since in the future it might get upgraded to a version requiring flake8 6.x ?
(or would pip be smart enough to pick that version then? :thinking:)
at least it would follow the style of all other deps here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] XN137 commented on a diff in pull request #6270: Python-legacy: Pin flake8
Posted by GitBox <gi...@apache.org>.
XN137 commented on code in PR #6270:
URL: https://github.com/apache/iceberg/pull/6270#discussion_r1032407392
##########
python_legacy/tox.ini:
##########
@@ -49,7 +49,7 @@ commands =
basepython = python3
skip_install = true
deps =
- flake8>=3.8.4
+ flake8==5.0.4
flake8-import-order>=0.9
Review Comment:
should we pin this as well maybe, since in the future it might get upgraded to a version requiring flake8 6.x ?
(or would pip be smart enough to not pick that version then? :thinking:)
at least it would follow the style of all other deps here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #6270: Python-legacy: Pin flake8
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #6270:
URL: https://github.com/apache/iceberg/pull/6270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #6270: Python-legacy: Pin flake8
Posted by GitBox <gi...@apache.org>.
Fokko commented on code in PR #6270:
URL: https://github.com/apache/iceberg/pull/6270#discussion_r1032418152
##########
python_legacy/tox.ini:
##########
@@ -49,7 +49,7 @@ commands =
basepython = python3
skip_install = true
deps =
- flake8>=3.8.4
+ flake8==5.0.4
flake8-import-order>=0.9
Review Comment:
Makes sense 👍🏻
```suggestion
flake8-import-order==0.18.1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] XN137 commented on a diff in pull request #6270: Python-legacy: Pin flake8
Posted by GitBox <gi...@apache.org>.
XN137 commented on code in PR #6270:
URL: https://github.com/apache/iceberg/pull/6270#discussion_r1032407392
##########
python_legacy/tox.ini:
##########
@@ -49,7 +49,7 @@ commands =
basepython = python3
skip_install = true
deps =
- flake8>=3.8.4
+ flake8==5.0.4
flake8-import-order>=0.9
Review Comment:
should we pin this as well maybe, since in the future it might get upgraded to a version requiring flake8 6.x ?
(or would pi be smart enough to upgrade to that version then? :thinking:)
at least it would follow the style of all other deps here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] XN137 commented on a diff in pull request #6270: Python-legacy: Pin flake8
Posted by GitBox <gi...@apache.org>.
XN137 commented on code in PR #6270:
URL: https://github.com/apache/iceberg/pull/6270#discussion_r1032407392
##########
python_legacy/tox.ini:
##########
@@ -49,7 +49,7 @@ commands =
basepython = python3
skip_install = true
deps =
- flake8>=3.8.4
+ flake8==5.0.4
flake8-import-order>=0.9
Review Comment:
should we pin this as well maybe, since in the future it might get upgraded to a version requiring flake8 6.x ?
would follow the style of all other deps here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org