You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/23 20:20:11 UTC

[GitHub] [arrow] zeroshade opened a new pull request #12233: ARROW-15418: [Go][Flight] Update gRPC version, hide impl details

zeroshade opened a new pull request #12233:
URL: https://github.com/apache/arrow/pull/12233


   Updating the version of gRPC used and re-generating the protobuf files. Shifting the generated files to an internal directory and then using aliases to better control the names and what is exported so that future updates can be done without being breaking like this one is. This will go out with v8 and thus is okay to be a breaking change since it will be a major version change (and will be noted in the release notes). 
   
   It also smooths out the interface for Flight a bit as a result of the gRPC updates, making it easier and more obvious when creating flight servers and the corresponding auth handling.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12233: ARROW-15418: [Go][Flight] Update gRPC version, hide impl details

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12233:
URL: https://github.com/apache/arrow/pull/12233#issuecomment-1032715453


   Benchmark runs are scheduled for baseline = 5a0ebb8aaa2dfabca072d18d9bea53fe813f519b and contender = 49d2a41280e191bb95f76595e7eb68958cc03990. 49d2a41280e191bb95f76595e7eb68958cc03990 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4fa93758ae204b798450ac2daa6ec299...efd7e624ddba4f1aa0eb3eef0ea40168/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fa016fb74ea48a0b9419d2aa30bb601...651a0e265f994f6ab0c2a947703cdc3e/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/50fec79450a4424c96f71636e2fe178c...168d220db887463c9d087d5d4c2d2474/)
   [Finished :arrow_down:0.17% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/714ed4990b994b37886317ebea9e4f3a...918e429f2ec24e2999e48a367866881c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12233: ARROW-15418: [Go][Flight] Update gRPC version, hide impl details

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12233:
URL: https://github.com/apache/arrow/pull/12233#issuecomment-1032715453


   Benchmark runs are scheduled for baseline = 5a0ebb8aaa2dfabca072d18d9bea53fe813f519b and contender = 49d2a41280e191bb95f76595e7eb68958cc03990. 49d2a41280e191bb95f76595e7eb68958cc03990 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4fa93758ae204b798450ac2daa6ec299...efd7e624ddba4f1aa0eb3eef0ea40168/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fa016fb74ea48a0b9419d2aa30bb601...651a0e265f994f6ab0c2a947703cdc3e/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/50fec79450a4424c96f71636e2fe178c...168d220db887463c9d087d5d4c2d2474/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/714ed4990b994b37886317ebea9e4f3a...918e429f2ec24e2999e48a367866881c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12233: ARROW-15418: [Go][Flight] Update gRPC version, hide impl details

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12233:
URL: https://github.com/apache/arrow/pull/12233#issuecomment-1032715453


   Benchmark runs are scheduled for baseline = 5a0ebb8aaa2dfabca072d18d9bea53fe813f519b and contender = 49d2a41280e191bb95f76595e7eb68958cc03990. 49d2a41280e191bb95f76595e7eb68958cc03990 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4fa93758ae204b798450ac2daa6ec299...efd7e624ddba4f1aa0eb3eef0ea40168/)
   [Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fa016fb74ea48a0b9419d2aa30bb601...651a0e265f994f6ab0c2a947703cdc3e/)
   [Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/50fec79450a4424c96f71636e2fe178c...168d220db887463c9d087d5d4c2d2474/)
   [Finished :arrow_down:0.17% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/714ed4990b994b37886317ebea9e4f3a...918e429f2ec24e2999e48a367866881c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #12233: ARROW-15418: [Go][Flight] Update gRPC version, hide impl details

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12233:
URL: https://github.com/apache/arrow/pull/12233#issuecomment-1019559534


   https://issues.apache.org/jira/browse/ARROW-15418


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12233: ARROW-15418: [Go][Flight] Update gRPC version, hide impl details

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12233:
URL: https://github.com/apache/arrow/pull/12233#issuecomment-1032715453


   Benchmark runs are scheduled for baseline = 5a0ebb8aaa2dfabca072d18d9bea53fe813f519b and contender = 49d2a41280e191bb95f76595e7eb68958cc03990. 49d2a41280e191bb95f76595e7eb68958cc03990 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4fa93758ae204b798450ac2daa6ec299...efd7e624ddba4f1aa0eb3eef0ea40168/)
   [Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fa016fb74ea48a0b9419d2aa30bb601...651a0e265f994f6ab0c2a947703cdc3e/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/50fec79450a4424c96f71636e2fe178c...168d220db887463c9d087d5d4c2d2474/)
   [Finished :arrow_down:0.17% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/714ed4990b994b37886317ebea9e4f3a...918e429f2ec24e2999e48a367866881c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] zeroshade closed pull request #12233: ARROW-15418: [Go][Flight] Update gRPC version, hide impl details

Posted by GitBox <gi...@apache.org>.
zeroshade closed pull request #12233:
URL: https://github.com/apache/arrow/pull/12233


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot commented on pull request #12233: ARROW-15418: [Go][Flight] Update gRPC version, hide impl details

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12233:
URL: https://github.com/apache/arrow/pull/12233#issuecomment-1032715453


   Benchmark runs are scheduled for baseline = 5a0ebb8aaa2dfabca072d18d9bea53fe813f519b and contender = 49d2a41280e191bb95f76595e7eb68958cc03990. 49d2a41280e191bb95f76595e7eb68958cc03990 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4fa93758ae204b798450ac2daa6ec299...efd7e624ddba4f1aa0eb3eef0ea40168/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fa016fb74ea48a0b9419d2aa30bb601...651a0e265f994f6ab0c2a947703cdc3e/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/50fec79450a4424c96f71636e2fe178c...168d220db887463c9d087d5d4c2d2474/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/714ed4990b994b37886317ebea9e4f3a...918e429f2ec24e2999e48a367866881c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12233: ARROW-15418: [Go][Flight] Update gRPC version, hide impl details

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12233:
URL: https://github.com/apache/arrow/pull/12233#issuecomment-1032715453


   Benchmark runs are scheduled for baseline = 5a0ebb8aaa2dfabca072d18d9bea53fe813f519b and contender = 49d2a41280e191bb95f76595e7eb68958cc03990. 49d2a41280e191bb95f76595e7eb68958cc03990 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4fa93758ae204b798450ac2daa6ec299...efd7e624ddba4f1aa0eb3eef0ea40168/)
   [Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fa016fb74ea48a0b9419d2aa30bb601...651a0e265f994f6ab0c2a947703cdc3e/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/50fec79450a4424c96f71636e2fe178c...168d220db887463c9d087d5d4c2d2474/)
   [Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/714ed4990b994b37886317ebea9e4f3a...918e429f2ec24e2999e48a367866881c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12233: ARROW-15418: [Go][Flight] Update gRPC version, hide impl details

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12233:
URL: https://github.com/apache/arrow/pull/12233#issuecomment-1032715453


   Benchmark runs are scheduled for baseline = 5a0ebb8aaa2dfabca072d18d9bea53fe813f519b and contender = 49d2a41280e191bb95f76595e7eb68958cc03990. 49d2a41280e191bb95f76595e7eb68958cc03990 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4fa93758ae204b798450ac2daa6ec299...efd7e624ddba4f1aa0eb3eef0ea40168/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fa016fb74ea48a0b9419d2aa30bb601...651a0e265f994f6ab0c2a947703cdc3e/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/50fec79450a4424c96f71636e2fe178c...168d220db887463c9d087d5d4c2d2474/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/714ed4990b994b37886317ebea9e4f3a...918e429f2ec24e2999e48a367866881c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org