[GitHub] [samza] nickpan47 commented on a diff in pull request #1628: SAMZA-2757 : Make Samza Compatible with Java 11

[GitBox <gi...@apache.org>]

nickpan47 commented on code in PR #1628:
URL: https://github.com/apache/samza/pull/1628#discussion_r988552047


##########
build.gradle:
##########
@@ -590,6 +660,73 @@ project(":samza-shell") {
   }
 }
 
+project(":samza-shell-yarn3") {
+  apply plugin: 'java'
+
+  configurations {
+    gradleShell
+  }
+
+  dependencies {
+    gradleShell project(":samza-core_$scalaSuffix")
+    gradleShell project(":samza-kafka_$scalaSuffix")
+    gradleShell project(":samza-test_$scalaSuffix")
+    gradleShell project(":samza-yarn3_$scalaSuffix")
+  }
+
+  task shellTarGz(type: Tar) {
+    compression = Compression.GZIP
+    classifier = 'dist'
+    from 'src/main/bash'

Review Comment:
   Are you sure that this works? I pulled down the PR and built locally. Only found that the corresponding samza-shell-yarn3 build does not yield any tgz file as output in build/distribution, since there is no separate samza-shell-yarn3/src in the source repo.



##########
build.gradle:
##########
@@ -590,6 +660,73 @@ project(":samza-shell") {
   }
 }
 
+project(":samza-shell-yarn3") {
+  apply plugin: 'java'
+
+  configurations {
+    gradleShell
+  }
+
+  dependencies {
+    gradleShell project(":samza-core_$scalaSuffix")
+    gradleShell project(":samza-kafka_$scalaSuffix")
+    gradleShell project(":samza-test_$scalaSuffix")
+    gradleShell project(":samza-yarn3_$scalaSuffix")
+  }
+
+  task shellTarGz(type: Tar) {
+    compression = Compression.GZIP
+    classifier = 'dist'
+    from 'src/main/bash'

Review Comment:
   Made the following change here and the build command successfully generates the samza-shell-yarn3 .tgz file:
   
   `
   -    from 'src/main/bash'
   -    from 'src/main/resources'
   -    from 'src/main/visualizer'
   +    from(project(":samza-shell").file("./src/main/bash"))
   +    from(project(":samza-shell").file("./src/main/resources"))
   +    from(project(":samza-shell").file("./src/main/visualizer"))
   `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org