You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/09 10:44:41 UTC

[GitHub] zentol commented on issue #7409: [FLINK-11064] [table] Setup a new flink-table module structure

zentol commented on issue #7409: [FLINK-11064] [table] Setup a new flink-table module structure
URL: https://github.com/apache/flink/pull/7409#issuecomment-452652632
 
 
   @bowenli86 I disagree. A PR being very large and difficult to review cannot be an argument for merging it as-is and fixing it later; if anything this is grounds for out-right rejecting it.
   
   This PR is only this large because classes were moved at the same time. What we could've done is adding the new modules without moving anything or changing flink-table, i.e., only add dependencies and add additional stuff to build systems / infrastructure.
   Then, in a subsequent PR, move classes and remove flink-table dependencies.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services