You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/23 01:24:50 UTC

[GitHub] [shardingsphere] tuichenchuxin commented on a diff in pull request #22285: [WIP] add `HintValueContext` for optimize hint.

tuichenchuxin commented on code in PR #22285:
URL: https://github.com/apache/shardingsphere/pull/22285#discussion_r1029953045


##########
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/QueryContext.java:
##########
@@ -38,10 +40,23 @@ public final class QueryContext {
     
     private String sqlStatementDatabaseName;
     
+    private HintValueContext hintValueContext;
+    
     public QueryContext(final SQLStatementContext<?> sqlStatementContext, final String sql, final List<Object> params) {
         this.sqlStatementContext = sqlStatementContext;
         this.sql = sql;
         parameters = params;
+        this.hintValueContext = SQLHintUtils.extractHint(sql);

Review Comment:
   For this kind of untransferred, should we just not extract it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org