[jira] [Updated] (AIRFLOW-4771) Initialization of hook in the GCP operator constructors

["Ash Berlin-Taylor (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AIRFLOW-4771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ash Berlin-Taylor updated AIRFLOW-4771:
---------------------------------------
    Fix Version/s:     (was: 1.10.6)
                   2.0.0

This one is not easy to backport due to all the renames that have gone on with GCP.

> Initialization of hook in the GCP operator constructors
> -------------------------------------------------------
>
>                 Key: AIRFLOW-4771
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4771
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: gcp
>    Affects Versions: 1.10.3
>            Reporter: Kamil Bregula
>            Priority: Major
>             Fix For: 2.0.0
>
>
> Hello,
> This affects following operators:
>  * BigtableInstanceCreateOperator
>  * BigtableInstanceDeleteOperator
>  * BigtableTableCreateOperator
>  * BigtableTableDeleteOperator
>  * BigtableClusterUpdateOperator
>  * BigtableTableWaitForReplicationSensor
>  * GceBaseOperator
>  * GcfFunctionDeployOperator
>  * GcfFunctionDeleteOperator
>  * CloudSpannerInstanceDeployOperator
>  * CloudSpannerInstanceDeleteOperator
>  * CloudSpannerInstanceDatabaseQueryOperator
>  * CloudSpannerInstanceDatabaseDeployOperator
>  * CloudSpannerInstanceDatabaseUpdateOperator
>  * CloudSpannerInstanceDatabaseDeleteOperator
>  * CloudSqlBaseOperator
>  * CloudVisionProductSetCreateOperator
>  * and more...
> This is not good practice for two reasons:
>  * The gcp_conn_id parameter can not be a Jinja template. Templates are resolved before calling the execute method, but after constrcutor.
>  * Hook initialization calls the database connection, because In the GoogleCloudBaseHook class, we have a code snippet:
> {code:java}
> def __init__(self, gcp_conn_id='google_cloud_default', delegate_to=None):
>     self.gcp_conn_id = gcp_conn_id
>     self.delegate_to = delegate_to
>     self.extras = self.get_connection(self.gcp_conn_id).extra_dejson
> {code}
> self.get_connection triggers a database query.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)