You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/22 05:06:00 UTC

[GitHub] szha commented on a change in pull request #10957: Make inner transform activation configurable for LSTMCell

szha commented on a change in pull request #10957: Make inner transform activation configurable for LSTMCell
URL: https://github.com/apache/incubator-mxnet/pull/10957#discussion_r189778302
 
 

 ##########
 File path: python/mxnet/gluon/rnn/rnn_cell.py
 ##########
 @@ -255,8 +256,7 @@ def _get_activation(self, F, inputs, activation, **kwargs):
             return F.Activation(inputs, act_type=activation, **kwargs)
 
 Review comment:
   for string type, map the string to the most efficient operator. for example, if the string is 'tanh', instead of doing `F.Activation(act_type='tanh')`, do `F.tanh`, which doesn't require parsing the string at each call.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services