[jira] [Commented] (SOLR-3526) Remove classfile dependency on ZooKeeper from CoreContainer

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292082#comment-13292082 ] 

Hoss Man commented on SOLR-3526:
--------------------------------

I'll defer on the large topic to miller/yonik/sami, but as to a specific comment...

bq. Now UpdateRequestProcessorChain is inserting a DistributedUpdateProcessor into my chains, again triggering a NPE when trying to dereference the CoreDescriptor.

...please note the updated javadocs for UpdateRequestProcessorChain.init... 

{noformat}
  /**
   * Initializes the chain using the factories specified by the <code>PluginInfo</code>.
   * if the chain includes the <code>RunUpdateProcessorFactory</code>, but 
   * does not include an implementation of the 
   * <code>DistributingUpdateProcessorFactory</code> interface, then an 
   * instance of <code>DistributedUpdateProcessorFactory</code> will be 
   * injected immediately prior to the <code>RunUpdateProcessorFactory</code>.
   *
   * @see DistributingUpdateProcessorFactory
   * @see RunUpdateProcessorFactory
   * @see DistributedUpdateProcessorFactory
   */
{noformat}

...and note the existence of NoOpDistributingUpdateProcessorFactory...

{noformat}
/**
 * A No-Op implementation of DistributingUpdateProcessorFactory that 
 * allways returns null.
 * <p> 
 * This implementation may be useful for Solr installations in which neither 
 * the <code>{@link DistributedUpdateProcessorFactory}</code> nor any custom 
 * implementation of <code>{@link DistributingUpdateProcessorFactory}</code> 
 * is desired (ie: shards are managed externally from Solr)
 * </p>
 */
{noformat}



                
> Remove classfile dependency on ZooKeeper from CoreContainer
> -----------------------------------------------------------
>
>                 Key: SOLR-3526
>                 URL: https://issues.apache.org/jira/browse/SOLR-3526
>             Project: Solr
>          Issue Type: Wish
>          Components: SolrCloud
>    Affects Versions: 4.0
>            Reporter: Michael Froh
>
> We are using Solr as a library embedded within an existing application, and are currently developing toward using 4.0 when it is released.
> We are currently instantiating SolrCores with null CoreDescriptors (and hence no CoreContainer), since we don't need SolrCloud functionality (and do not want to depend on ZooKeeper).
> A couple of months ago, SearchHandler was modified to try to retrieve a ShardHandlerFactory from the CoreContainer. I was able to work around this by specifying a dummy ShardHandlerFactory in the config.
> Now UpdateRequestProcessorChain is inserting a DistributedUpdateProcessor into my chains, again triggering a NPE when trying to dereference the CoreDescriptor.
> I would happily place the SolrCores in CoreContainers, except that CoreContainer imports and references org.apache.zookeeper.KeeperException, which we do not have (and do not want) in our classpath. Therefore, I get a ClassNotFoundException when loading the CoreContainer class.
> Ideally (IMHO), ZkController should isolate the ZooKeeper dependency, and simply rethrow KeeperExceptions as org.apache.solr.common.cloud.ZooKeeperException (or some Solr-hosted checked exception). Then CoreContainer could remove the offending import/references.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org