You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "kiranchavala (via GitHub)" <gi...@apache.org> on 2026/03/13 08:14:56 UTC
[I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
kiranchavala opened a new issue, #12810:
URL: https://github.com/apache/cloudstack/issues/12810
### problem
Global setting "consoleproxy.session.timeout " is not honoured
### versions
ACS 4.22 , kvm
### The steps to reproduce the bug
Steps to reproduce the issue
1. Check the global setting parameter “consoleproxy.session.timeout” the default value is set to 300000 ms which 5 min
2. Launch a vms with admin role, domain admin role and a user role
3. Take the console session of the vm’s from admin role, domain admin role and a user role
4. The console session doesn’t get timed out after 5 min
### What to do about it?
Expected behaviour
The console session of the vm should get timed out after 5 min
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4273052605
> Is it possible to get this fix back ported to the 4.22 LTS version? It is my understanding 4.23 is not LTS.
If the fix is accepted, I’m happy to help by opening a backport PR against the 4.22 branch if maintainers think that’s appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4211609656
> I’ve implemented code changes for this issue so that consoleproxy.session.timeout (in milliseconds) is read in ConsoleProxy, passed into the console proxy process, and then used by both the noVNC WebSocket session handling and the GC thread for idle session cleanup.
>
> The changes are in the following files:
>
> services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxy.java
>
> services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java
>
> services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyGCThread.java
That's good. Is there a draft PR, I can check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4287988085
I think it is appropriate @dheeraj12347 go ahead and rebase it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4169528065
Hi @DaanHoogland ,
No, I haven't created any experimental code yet. I'm starting with analysis: tracing how consoleproxy.session.timeout is read from globals, passed to CPVM, and enforced in session lifecycle. Any specific files or paths to prioritize? Can proceed with a draft PR once I identify the gap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4206961835
I’ve implemented code changes for this issue so that consoleproxy.session.timeout (in milliseconds) is read in ConsoleProxy, passed into the console proxy process, and then used by both the noVNC WebSocket session handling and the GC thread for idle session cleanup.
The changes are in the following files:
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxy.java
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyGCThread.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4169171179
@dheeraj12347 , are you creating (experimental) code for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4273052390
> Is it possible to get this fix back ported to the 4.22 LTS version? It is my understanding 4.23 is not LTS.
Regarding backporting to 4.22 LTS: I’m not a release manager, so I can’t decide that myself, but once the PR is reviewed and merged the maintainers can consider backporting it to the 4.22 branch if it meets their criteria.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4170217779
I think this will go in the systemvm code and needs to be propagated from the service in the `services/console-proxy` project. I would have to search as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4206109058
@dheeraj12347 Let me know if you need any help with fixing this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4299139496
> I think it is appropriate [@dheeraj12347](https://github.com/dheeraj12347) go ahead and rebase it. I would actually suggest the 4.20 branch
Thanks, @dahn.
I’ve rebased this onto the `4.20` branch and opened the backport PR as suggested.
This PR now targets `apache:4.20` (`backport-12810-consoleproxy-timeout-4.20` on my fork) and builds cleanly:
```bash
mvn -pl services/console-proxy/server -am -DskipTests compile
```
Please let me know if you’d like any further adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4175363052
> I think this will go in the systemvm code and needs to be propagated from the service in the `services/console-proxy` project. I would have to search as well.
Thanks, that clarifies it.
I’ll start working on this issue. My next steps will be:
- Look into the SystemVM/CPVM side and the `services/console-proxy` project to see how console proxy configuration is currently propagated, and
- Add/enforce the `consoleproxy.session.timeout` value in the console proxy session handling so that console sessions respect the configured timeout.
Once I have something concrete, I’ll open a draft PR .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "DRossII (via GitHub)" <gi...@apache.org>.
DRossII commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4268085165
Is it possible to get this fix back ported to the 4.22 LTS version? It is my understanding 4.23 is not LTS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Global setting "consoleproxy.session.timeout " is not honoured [cloudstack]
Posted by "dheeraj12347 (via GitHub)" <gi...@apache.org>.
dheeraj12347 commented on issue #12810:
URL: https://github.com/apache/cloudstack/issues/12810#issuecomment-4228360869
> > I’ve implemented code changes for this issue so that consoleproxy.session.timeout (in milliseconds) is read in ConsoleProxy, passed into the console proxy process, and then used by both the noVNC WebSocket session handling and the GC thread for idle session cleanup.
> > The changes are in the following files:
> > services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxy.java
> > services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java
> > services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyGCThread.java
>
> That's good. Is there a draft PR, I can check?
@vishesh92 I have drafted the PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org