You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2017/08/06 02:26:01 UTC
[GitHub] spark pull request #18856: [SPARKR][BUILD] AppVeyor change to latest R versi...
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/18856
[SPARKR][BUILD] AppVeyor change to latest R version
## What changes were proposed in this pull request?
R version update
## How was this patch tested?
AppVeyor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felixcheung/spark rappveyorver
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18856.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18856
----
commit 2449e7e5488e8f59860123b6681c90b9415b9a3c
Author: Felix Cheung <fe...@hotmail.com>
Date: 2017-08-06T02:24:42Z
change to latest R version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18856
Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18856
It's the latest but it's not new - 3.4.1 was release a month ago. I think there shouldn't be the sync problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18856
Ah, I meant, the PR I linked actually describes a case when we were using 3.3.1 but it was broken after 3.3.2 release. The reason was, 3.3.2 was released but 3.3.2 for Windows was not synced (but was synced after few hours).
The script we are using checks if it is latest or not and adds `../old/..` part to build the download link correctly. So..
- Check given version is latest via https://rversions.r-pkg.org/r-release
- If so, don't add `../old/..`, e.g., https://cran.r-project.org/bin/windows/base/R-3.3.1-win.exe
- if not, add `../old/..`, e.g., https://cran.r-project.org/bin/windows/base/old/3.3.1/R-3.3.1-win.exe
But, the issue was, https://rversions.r-pkg.org/r-release gives 3.3.2 after the release but 3.3.1 for WIndows was not in old repo as the latest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18856
@felixcheung, actually, should we try to replace `http://rversions.r-pkg.org/r-release` in line 29 to `http://rversions.r-pkg.org/r-release-win`? I referred https://github.com/krlmlr/r-appveyor/commit/01ce943929993bbf27facd2cdc20ae2e03808eb4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18856: [SPARKR][BUILD] AppVeyor change to latest R versi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18856
I agree this PR should be okay alone, which fixes what it targets for now and I realised my suggestion is rather an extra bit. I opened another one for replacing `r-release` to `r-release-win`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18856
To cut this short, it was ...
- 3.3.2 release for Linux only
- Gives the latest as 3.3.2 and the download link for 3.3.1 becomes `windows/base/old`
- 3.3.2 release for WIndows yet
- 3.3.1 is still not in `windows/base/old` but `windows/base`
- Failed to download
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18856
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18856
**[Test build #80291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80291/testReport)** for PR 18856 at commit [`2449e7e`](https://github.com/apache/spark/commit/2449e7e5488e8f59860123b6681c90b9415b9a3c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18856
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80291/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18856
Will try to open a separate PR. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18856
@felixcheung, BTW, I think optionally we could also consider setting it 3.4.0 a bit more conservatively for now. There was a rather minor problem for using the latest version (see https://github.com/apache/spark/pull/15709) due to sync'ing issue of R version, which was fixed within few hours outside Spark IIRC. Either way is fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18856
Right, this PR isn't changing how you have made the version to test with sticky - we won't still pick up the latest automatically, which is fine for now.
But we should bump (manually) to the later/latest version in one of the test matrix to make sure it works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18856: [SPARKR][BUILD] AppVeyor change to latest R version
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18856
**[Test build #80291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80291/testReport)** for PR 18856 at commit [`2449e7e`](https://github.com/apache/spark/commit/2449e7e5488e8f59860123b6681c90b9415b9a3c).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org