You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/11 21:32:00 UTC
[GitHub] [incubator-nuttx] tmedicci opened a new pull request, #6837: Framebuffer lcddev buffer/master
tmedicci opened a new pull request, #6837:
URL: https://github.com/apache/incubator-nuttx/pull/6837
## Summary
PR following the discussion in https://github.com/apache/incubator-nuttx/pull/6657
In summary, LCD device driver and framebuffer are not able to use both the same `putarea` implementations of the LCD driver.
General picture is also described at the first commit description.
## Impact
This impacts the way LCD displays refresh an area.
## Testing
Tested with both LVGL simulator config (LCD and FB) as well as with the TTGO T-Display board (which contains a st7789 TFT display).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6837: Framebuffer and lcddev buffer usage for LCD displays drivers
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6837:
URL: https://github.com/apache/incubator-nuttx/pull/6837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6837: Framebuffer and lcddev buffer usage for LCD displays drivers
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6837:
URL: https://github.com/apache/incubator-nuttx/pull/6837#discussion_r944048044
##########
include/nuttx/lcd/lcd.h:
##########
@@ -90,7 +92,8 @@ struct lcd_planeinfo_s
int (*putarea)(FAR struct lcd_dev_s *dev, fb_coord_t row_start,
fb_coord_t row_end, fb_coord_t col_start,
- fb_coord_t col_end, FAR const uint8_t *buffer);
+ fb_coord_t col_end, FAR const uint8_t *buffer,
+ fb_coord_t stride);
Review Comment:
let add the same parameter to get_area too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6837: Framebuffer and lcddev buffer usage for LCD displays drivers
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6837:
URL: https://github.com/apache/incubator-nuttx/pull/6837#discussion_r944048044
##########
include/nuttx/lcd/lcd.h:
##########
@@ -90,7 +92,8 @@ struct lcd_planeinfo_s
int (*putarea)(FAR struct lcd_dev_s *dev, fb_coord_t row_start,
fb_coord_t row_end, fb_coord_t col_start,
- fb_coord_t col_end, FAR const uint8_t *buffer);
+ fb_coord_t col_end, FAR const uint8_t *buffer,
+ fb_coord_t stride);
Review Comment:
let add the same parameter to getarea too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] lupyuen commented on pull request #6837: Framebuffer and lcddev buffer usage for LCD displays drivers
Posted by GitBox <gi...@apache.org>.
lupyuen commented on PR #6837:
URL: https://github.com/apache/incubator-nuttx/pull/6837#issuecomment-1221235529
Thanks @tmedicci! This works great on the ST7789 Display for PineDio Stack BL604. I have changed `LCDDEVIO_PUTRUN` back to `LCDDEVIO_PUTAREA` in my LVGL demo: https://github.com/apache/incubator-nuttx/pull/6657#issuecomment-1204657460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tmedicci commented on a diff in pull request #6837: Framebuffer and lcddev buffer usage for LCD displays drivers
Posted by GitBox <gi...@apache.org>.
tmedicci commented on code in PR #6837:
URL: https://github.com/apache/incubator-nuttx/pull/6837#discussion_r944432957
##########
include/nuttx/lcd/lcd.h:
##########
@@ -90,7 +92,8 @@ struct lcd_planeinfo_s
int (*putarea)(FAR struct lcd_dev_s *dev, fb_coord_t row_start,
fb_coord_t row_end, fb_coord_t col_start,
- fb_coord_t col_end, FAR const uint8_t *buffer);
+ fb_coord_t col_end, FAR const uint8_t *buffer,
+ fb_coord_t stride);
Review Comment:
Yes, it makes total sense! I'll update the PR, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tmedicci commented on a diff in pull request #6837: Framebuffer and lcddev buffer usage for LCD displays drivers
Posted by GitBox <gi...@apache.org>.
tmedicci commented on code in PR #6837:
URL: https://github.com/apache/incubator-nuttx/pull/6837#discussion_r944480529
##########
include/nuttx/lcd/lcd.h:
##########
@@ -90,7 +92,8 @@ struct lcd_planeinfo_s
int (*putarea)(FAR struct lcd_dev_s *dev, fb_coord_t row_start,
fb_coord_t row_end, fb_coord_t col_start,
- fb_coord_t col_end, FAR const uint8_t *buffer);
+ fb_coord_t col_end, FAR const uint8_t *buffer,
+ fb_coord_t stride);
Review Comment:
Updated it ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tmedicci commented on pull request #6837: Framebuffer and lcddev buffer usage for LCD displays drivers
Posted by GitBox <gi...@apache.org>.
tmedicci commented on PR #6837:
URL: https://github.com/apache/incubator-nuttx/pull/6837#issuecomment-1213286708
need to fix a small bugfix for gc9a01 LCD driver. Just a minute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tmedicci commented on pull request #6837: Framebuffer and lcddev buffer usage for LCD displays drivers
Posted by GitBox <gi...@apache.org>.
tmedicci commented on PR #6837:
URL: https://github.com/apache/incubator-nuttx/pull/6837#issuecomment-1213518239
@acassis , if possible, can you test this with the APA102-based LCD matrix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org