[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22042: Update Oracle DML SLELECT PERCENT_RANK statement parse

[GitBox <gi...@apache.org>]

RaigorJiang commented on code in PR #22042:
URL: https://github.com/apache/shardingsphere/pull/22042#discussion_r1017838108


##########
sql-parser/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/statement/impl/OracleStatementSQLVisitor.java:
##########
@@ -519,7 +519,7 @@ private ASTNode createAggregationSegment(final AggregationFunctionContext ctx, f
     }
     
     private Collection<ExpressionSegment> getExpressions(final AggregationFunctionContext ctx) {
-        return null == ctx.expr() ? Collections.emptyList() : Collections.singletonList((ExpressionSegment) visit(ctx.expr()));
+        return null == ctx.exprs() ? Collections.emptyList() : Collections.singletonList((ExpressionSegment) visit(ctx.exprs()));

Review Comment:
   Hi @Qianyi951015 , I found that there is not method to visit ExprsContext, so this line will not give the expected result.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org