You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/07/22 16:31:01 UTC
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3480:
[WIP DO NOT MERGE] engine, server,
services: fix for respecting secondary storage threshold limit
rhtyd commented on a change in pull request #3480: [WIP DO NOT MERGE] engine, server, services: fix for respecting secondary storage threshold limit
URL: https://github.com/apache/cloudstack/pull/3480#discussion_r305917156
##########
File path: engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreManager.java
##########
@@ -33,7 +33,11 @@
List<DataStore> getImageStoresByScope(ZoneScope scope);
- DataStore getImageStore(long zoneId);
+ DataStore getImageStoreForRead(long zoneId);
+
+ DataStore getImageStoreForWrite(long zoneId);
+
+ List<DataStore> getImageStoresForWrite(long zoneId);
Review comment:
Rename it something more meaningful like `listImagesStoresWithFreeCapacity`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services