You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@annotator.apache.org by GitBox <gi...@apache.org> on 2021/11/08 02:05:55 UTC
[GitHub] [incubator-annotator] tilgovi commented on a change in pull request #117: Run tests as ECMAScript modules
tilgovi commented on a change in pull request #117:
URL: https://github.com/apache/incubator-annotator/pull/117#discussion_r744361773
##########
File path: packages/dom/src/css.ts
##########
@@ -20,10 +20,10 @@
* under the License.
*/
-import optimalSelect from 'optimal-select';
+import { finder } from '@medv/finder';
import type { CssSelector, Matcher } from '@apache-annotator/selector';
-import { ownerDocument } from './owner-document';
-import { toRange } from './to-range';
+import { ownerDocument } from './owner-document.js';
+import { toRange } from './to-range.js';
Review comment:
I'm not getting linter errors locally or in CI. Using a `.ts` ending is wrong because TypeScript doesn't like it and it would require rewriting to be correct after compilation. I'll see what I can do about webpack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@annotator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org