You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/01 06:18:14 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #22658: Fix incorrect data_interval_start due to scheduling time change

uranusjr commented on a change in pull request #22658:
URL: https://github.com/apache/airflow/pull/22658#discussion_r840267333



##########
File path: airflow/timetables/interval.py
##########
@@ -58,6 +58,10 @@ def _align(self, current: DateTime) -> DateTime:
         """
         raise NotImplementedError()
 
+    def _align_to_prev(self, current: DateTime) -> DateTime:
+        """Align given time to the scheduled."""

Review comment:
       Please
   
   1. Add more description on what this function does (similar to the docstring for `_align_to_next`)
   2. Describe _why_ this is different from `self._prev(self._align_to_next(t))` (when a DAG’s schedule changes, as you mentioned in the original PR).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org