[GitHub] [parquet-mr] imperio-wxm commented on a change in pull request #620: PARQUET-1531: Page row count limit causes empty pages to be written from MessageColumnIO

[GitBox <gi...@apache.org>]

imperio-wxm commented on a change in pull request #620:
URL: https://github.com/apache/parquet-mr/pull/620#discussion_r456351864



##########
File path: parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterBase.java
##########
@@ -305,6 +305,9 @@ long getRowsWrittenSoFar() {
    * Writes the current data to a new page in the page store
    */
   void writePage() {
+    if (valueCount == 0) {
+      throw new ParquetEncodingException("writing empty page");

Review comment:
       > @rdblue , @gszadovszky ... hi, sorry for writing this way, I think that probably write here direct to code would reach authors (as I'm starting to be despair :D ) .. I hit this error and don't know how to deal with it, I'm using it in MapReduce and do nothing special, provide WritteSupport and that's all...unfortunately I'm not able to reproduce it in any test,all test with my WriteSupport class passes ... here is my [ question on StackOverFlow](https://stackoverflow.com/questions/61776917/parquet-writer-org-apache-parquet-io-parquetencodingexception-writing-empty-pa) ... thanks for any help
   
   I encountered the same problem, how to solve it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org