You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@myfaces.apache.org by lu...@apache.org on 2014/01/02 22:14:21 UTC

svn commit: r1554919 - /myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java

Author: lu4242
Date: Thu Jan  2 21:14:20 2014
New Revision: 1554919

URL: http://svn.apache.org/r1554919
Log:
MYFACES-3836 f:ajax disabled=false in commandButton with onclick prevents form submission

Modified:
    myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java

Modified: myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java?rev=1554919&r1=1554918&r2=1554919&view=diff
==============================================================================
--- myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java (original)
+++ myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java Thu Jan  2 21:14:20 2014
@@ -1873,7 +1873,9 @@ public final class HtmlRendererUtils
                 target.append(", ");
             }
         }
-        if (!submitting)
+        // MYFACES-3836 If no script provided by the client behavior, ignore the 
+        // submitting hint because. it is evidence the client behavior is disabled.
+        if (script != null && !submitting)
         {
             submitting = clientBehavior.getHints().contains(
                     ClientBehaviorHint.SUBMITTING);