You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/25 12:29:11 UTC

[GitHub] [arrow] martin-g commented on a diff in pull request #13072: ARROW-16328: [Java] Proposal to upgrade Arrow Java project to JPMS Java Platform Module System

martin-g commented on code in PR #13072:
URL: https://github.com/apache/arrow/pull/13072#discussion_r881592518


##########
java/memory/memory-netty/pom.xml:
##########
@@ -69,4 +70,25 @@
       </build>
     </profile>
   </profiles>
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <configuration>
+          <compilerArgs combine.children="append">
+            <arg>--patch-module=io.netty.buffer=/Users/dsusanibar/.m2/repository/org/apache/arrow/memory-netty-buffer-patch/8.0.0-SNAPSHOT/memory-netty-buffer-patch-8.0.0-SNAPSHOT.jar</arg>

Review Comment:
   Use ` ${settings.localRepository}` instead of hardcoding the user



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org