You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/06 08:40:47 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
ustcweizhou opened a new pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383
## Description
<!--- Describe your changes in detail -->
If hosts have multiple host tags, the total/up/down hosts in prometheus exporter are not correct.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383#issuecomment-705101659
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2147
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383#issuecomment-704212512
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383#issuecomment-704311522
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383#issuecomment-704243183
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383#issuecomment-704623158
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2141
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383#issuecomment-708309073
LGTM, changes are strictly in promethus plugin; merging based on lgtms and travis tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383#issuecomment-704323758
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383#issuecomment-704345974
@ustcweizhou @DaanHoogland
Seems like the build failure is because it is unable to resolve HostVO and hostDao isn't injected
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project cloud-plugin-integrations-prometheus-exporter: Compilation failure: Compilation failure:
[ERROR] /jenkins/workspace/acs-pr-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.14.1.0-SNAPSHOT/plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java:[103,33] error: cannot find symbol
[ERROR] symbol: variable hostDao
[ERROR] location: class PrometheusExporterImpl
[ERROR] /jenkins/workspace/acs-pr-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.14.1.0-SNAPSHOT/plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java:[103,19] error: cannot find symbol
[ERROR] symbol: class HostVO
[ERROR] location: class PrometheusExporterImpl
[ERROR] -> [Help 1]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383#issuecomment-704211992
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383#issuecomment-704612362
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4383: Host is counted twice if it has multiple host tags in Prometheus exporter
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4383:
URL: https://github.com/apache/cloudstack/pull/4383#issuecomment-704612577
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org