You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (Jira)" <ji...@apache.org> on 2020/01/12 20:51:00 UTC
[jira] [Closed] (FLINK-15523) ConfigConstants generally excluded
from japicmp
[ https://issues.apache.org/jira/browse/FLINK-15523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chesnay Schepler closed FLINK-15523.
------------------------------------
Resolution: Fixed
master:
5c037f2690fd0459c2395f3f82428077a3207fd2
7a6ca9c03f67f488e40a114e94c389a5cfb67836
1.10:
584879551e5db3445b1e2f9a6789847e3e44a887
a08bc83c552f562c86c310124f29c7b12ee05613
1.9:
c33f0d25cb5d33667fd00dfdb94bb9704bda0fa9
1.8:
098adf45801efcd851923000303c33321e32bc0c
> ConfigConstants generally excluded from japicmp
> -----------------------------------------------
>
> Key: FLINK-15523
> URL: https://issues.apache.org/jira/browse/FLINK-15523
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.8.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.8.4, 1.9.2, 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It appears that {{ConfigConstants}}, despite being {{@Public}}, has been excluded from the japicmp check since {{1.5.0}}: [https://github.com/apache/flink/commit/1f9c2d9740ffea2b59b8f5f3da287a0dc890ddbf]
> This is a bit of a surprise to me and looks like a mistake (what's the point of excluding specific fields if the entire class is excluded), and if so this has repercussions on some ongoing work:
> {code:java}
> Breaking the build because there is at least one incompatibility: org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_SIZE_KEY:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_OFF_HEAP_KEY:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.DEFAULT_TASK_MANAGER_MEMORY_PRE_ALLOCATE:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_PRE_ALLOCATE_KEY:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.TASK_MANAGER_MEMORY_FRACTION_KEY:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.YARN_MAX_FAILED_CONTAINERS:FIELD_REMOVED,
> org.apache.flink.configuration.ConfigConstants.DEFAULT_MEMORY_MANAGER_MEMORY_FRACTION:FIELD_REMOVED
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)